Skip to content

patches: remove the icu and bison patches nothing applies - #4602

Merged
vvbandeira merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:cleanup-unused-bazel-patches
Oct 2, 2026
Merged

vvbandeira merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:cleanup-unused-bazel-patches

Conversation

@oharboe

@oharboe oharboe commented Oct 2, 2026

Copy link
Copy Markdown
Collaborator

patches/icu and patches/bison patched the icu and bison bazel modules for ORFS's own bazel build. ORFS no longer builds with bazel, and nothing in the tree reads either directory (git grep patches/ outside patches/ finds nothing).

Deletions only.

🤖 Generated with Claude Code

They patched the icu and bison bazel modules for ORFS's own bazel
build. ORFS no longer builds with bazel, and nothing in the tree reads
patches/icu or patches/bison.

Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces two key fixes. First, it modifies the Bazel build configuration for Bison to ensure Gnulib's wrapper headers correctly shadow libc headers by using explicit -I compiler options (BISON_COPTS) instead of includes = ["lib"] which emits -isystem. Second, it prevents a potential segmentation fault in icu4c/source/common/putil.cpp by verifying that Runfiles::Create() does not return a null pointer before attempting to resolve the ICU data directory path. There are no review comments, so we have no additional feedback to provide.

@oharboe
oharboe requested a review from maliberty October 2, 2026 07:12
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit daea823 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@vvbandeira
vvbandeira merged commit 5105b0a into The-OpenROAD-Project:master Oct 2, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants