Repository navigation
patches: remove the icu and bison patches nothing applies - #4602
Conversation
They patched the icu and bison bazel modules for ORFS's own bazel build. ORFS no longer builds with bazel, and nothing in the tree reads patches/icu or patches/bison. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
There was a problem hiding this comment.
Code Review
This pull request introduces two key fixes. First, it modifies the Bazel build configuration for Bison to ensure Gnulib's wrapper headers correctly shadow libc headers by using explicit -I compiler options (BISON_COPTS) instead of includes = ["lib"] which emits -isystem. Second, it prevents a potential segmentation fault in icu4c/source/common/putil.cpp by verifying that Runfiles::Create() does not return a null pointer before attempting to resolve the ICU data directory path. There are no review comments, so we have no additional feedback to provide.
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
patches/icuandpatches/bisonpatched the icu and bison bazel modules for ORFS's own bazel build. ORFS no longer builds with bazel, and nothing in the tree reads either directory (git grep patches/outsidepatches/finds nothing).Deletions only.
🤖 Generated with Claude Code