Repository navigation
docs: AutoMemories views come from FakeRAM2.0's asap7 backend - #4610
Merged
maliberty merged 1 commit intoOct 3, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the AutoMemories.md documentation to reflect that memory views are now generated using FakeRAM2.0's asap7 backend instead of the previous custom parametric models. The feedback suggests minor phrasing improvements to clarify that dimensions are snapped to a grid of 0.19 µm by 1.4 µm and to use the term 'process parameters' instead of 'process numbers' for better clarity and professionalism.
oharboe
force-pushed
the
memories-docs-fakeram-views
branch
2 times, most recently
from
October 3, 2026 06:50
181744a to
7af2ca6
Compare
The "Generated views" and "Platform support" sections described emitters that are not in the tree: scripts/memories/liberty.py, lef.py, pdk_asap7.py with a PdkParams seam, and sram_area_model.py with an area model anchored to an ISSCC 2018 paper. The views come from tools/FakeRAM2.0/orfs_asap7/generate.py. Describe what it emits: a single-port FakeRAM2.0 RAM per memory under FakeRAM2.0's pin names, fixed asap7 default timing and power, area from poly and fin pitch, an identical _pre_layout.lib, and the LEF's M4 pins, M4 power straps and M1-M4 OBS. Platform constants are hardcoded in ASAP7_PROCESS_CONFIG. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
force-pushed
the
memories-docs-fakeram-views
branch
from
October 3, 2026 07:03
7af2ca6 to
7f2c5a1
Compare
oharboe
marked this pull request as ready for review
October 3, 2026 07:07
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Corrects
AutoMemories.md's "Generated views" and "Platform support" sections, which describe emitters that don't exist (liberty.py,lef.py,pdk_asap7.py,sram_area_model.py).Views come from FakeRAM2.0's asap7 backend. The new text was checked against generated 16×32 and 1024×64 views: a single-port RAM with FakeRAM2.0's pin names, the same default timing and power for every memory, area from poly and fin pitch, and asap7 constants hardcoded in
generate.py. Docs only.🤖 Generated with Claude Code