Repository navigation
memories: run the in-tree FakeRAM2.0, drop FAKERAM_RUN_PY - #4611
Merged
maliberty merged 1 commit intoOct 3, 2026
Merged
Conversation
gen_memories.py found FakeRAM through FAKERAM_RUN_PY, or else by searching bazel's RUNFILES_DIR for a run.py under a directory named like "fakeram". Both date from a632406, when FakeRAM2.0 was a separate repository that ORFS's MODULE.bazel fetched. The same day it moved into ORFS (76a445c), so its location relative to this script is fixed. Nothing in the make flow ever set FAKERAM_RUN_PY, so AUTO_MEMORIES under make stopped with "FAKERAM_RUN_PY not set and FakeRAM run.py not found" unless the user exported it. The RUNFILES_DIR search could not match "FakeRAM2.0" (it is case-sensitive), and ORFS no longer builds with bazel. Run tools/FakeRAM2.0/run.py relative to this script, and drop the variable, the search and the test's bazel branch. A missing run.py now fails in the subprocess, which names the path. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the resolution of the FakeRAM executable path by replacing the dynamic find_fakeram_run function with a hardcoded relative path. Feedback suggests preserving support for the FAKERAM_RUN_PY environment variable as an optional override to maintain compatibility with hermetic build systems like Bazel, and adding an existence check for the executable path to prevent unhelpful Python tracebacks if the file is missing.
oharboe
marked this pull request as ready for review
October 3, 2026 07:06
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR:
gen_memories.pyruns the in-treetools/FakeRAM2.0/run.pydirectly, droppingFAKERAM_RUN_PY. Nothing set that variable, so AUTO_MEMORIES under plainmakefailed with "FAKERAM_RUN_PY not set".FAKERAM_RUN_PYand its bazelRUNFILES_DIRsearch date from a632406, when FakeRAM2.0 was a separate repository. It moved into ORFS the same day (76a445c). This drops the variable, the search (which never matchedFakeRAM2.0anyway) and the test's bazel branch. bazel-orfs is pinned and adapts when it bumps.Testing:
flow/scripts/memories/*_test.pypass with no environment set. With nothing exported,make ... tinyRocket synthnow runs FakeRAM and writes the macro views.🤖 Generated with Claude Code