Repository navigation
Conversation
Stragglers from The-OpenROAD-Project#4586, which removed the variable from variables.yaml and the gf12 bp_* designs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
force-pushed
the
drop-abc-clock-period-leftovers
branch
from
October 3, 2026 21:39
c4b64c7 to
3f977b6
Compare
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the ABC_CLOCK_PERIOD_IN_PS configuration variable from the synthesis settings in the config.mk files for both the picorv32 and tpu designs under the nangate45 platform. I have no feedback to provide as there are no review comments.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stragglers from #4586, which removed
ABC_CLOCK_PERIOD_IN_PSfromvariables.yamland the gf12bp_*designs.🤖 Generated with Claude Code