Skip to content

designs: drop ABC_CLOCK_PERIOD_IN_PS from nangate45 picorv32 and tpu - #4614

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:drop-abc-clock-period-leftovers
Oct 4, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:drop-abc-clock-period-leftovers

Conversation

@oharboe

@oharboe oharboe commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Stragglers from #4586, which removed ABC_CLOCK_PERIOD_IN_PS from variables.yaml and the gf12 bp_* designs.

🤖 Generated with Claude Code

Stragglers from The-OpenROAD-Project#4586, which removed the variable from variables.yaml
and the gf12 bp_* designs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
@oharboe
oharboe force-pushed the drop-abc-clock-period-leftovers branch from c4b64c7 to 3f977b6 Compare October 3, 2026 21:39
@oharboe
oharboe requested a review from maliberty October 3, 2026 21:39

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the ABC_CLOCK_PERIOD_IN_PS configuration variable from the synthesis settings in the config.mk files for both the picorv32 and tpu designs under the nangate45 platform. I have no feedback to provide as there are no review comments.

@openroad-ci

openroad-ci commented Oct 3, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit ad9ec3e · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty
maliberty merged commit 2aeb23b into The-OpenROAD-Project:master Oct 4, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants