Repository navigation
Conversation
The FAx1 and HAxp5 cells in the asap7sc7p5t_SIMPLE libraries have intentional CON->SN output-to-output timing arcs (mirror-adder topology, CON is reused internally by the sum stage). Explain this in liberty_suppressions.tcl so the arcs are not mistakenly removed from the Liberty files, and note that the suppression also hides STA-1212 for user-added libraries. Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the comments in liberty_suppressions.tcl for the ASAP7 platform to provide a detailed explanation of why the STA 1212 warning is suppressed. It explains the mirror-adder topology of the cells, the validity of the output-to-output timing arcs, and includes references to relevant discussions and pull requests. There are no review comments, and I have no feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The FAx1 and HAxp5 cells in the asap7sc7p5t_SIMPLE libraries have intentional CON->SN output-to-output timing arcs (mirror-adder topology, CON is reused internally by the sum stage). Explain this in liberty_suppressions.tcl so the arcs are not mistakenly removed from the Liberty files, and note that the suppression also hides STA-1212 for user-added libraries.