Skip to content

asap7: document why STA-1212 is suppressed - #4629

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:asap7-document-sta1212-suppression
Oct 8, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:asap7-document-sta1212-suppression

Conversation

@dsengupta0628

Copy link
Copy Markdown
Contributor

The FAx1 and HAxp5 cells in the asap7sc7p5t_SIMPLE libraries have intentional CON->SN output-to-output timing arcs (mirror-adder topology, CON is reused internally by the sum stage). Explain this in liberty_suppressions.tcl so the arcs are not mistakenly removed from the Liberty files, and note that the suppression also hides STA-1212 for user-added libraries.

The FAx1 and HAxp5 cells in the asap7sc7p5t_SIMPLE libraries have
intentional CON->SN output-to-output timing arcs (mirror-adder topology,
CON is reused internally by the sum stage). Explain this in
liberty_suppressions.tcl so the arcs are not mistakenly removed from the
Liberty files, and note that the suppression also hides STA-1212 for
user-added libraries.

Signed-off-by: dsengupta0628 <dsengupta@precisioninno.com>
@dsengupta0628 dsengupta0628 self-assigned this Oct 5, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the comments in liberty_suppressions.tcl for the ASAP7 platform to provide a detailed explanation of why the STA 1212 warning is suppressed. It explains the mirror-adder topology of the cells, the validity of the output-to-output timing arcs, and includes references to relevant discussions and pull requests. There are no review comments, and I have no feedback to provide.

@openroad-ci

openroad-ci commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 2671033 · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty
maliberty merged commit ef42174 into The-OpenROAD-Project:master Oct 8, 2026
12 checks passed
@maliberty
maliberty deleted the asap7-document-sta1212-suppression branch October 8, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants