From b0d1bf8f5c898edfff3a80b4b3acdbb8776820c0 Mon Sep 17 00:00:00 2001 From: dsengupta0628 Date: Mon, 5 Oct 2026 14:07:38 +0000 Subject: [PATCH] asap7: document why STA-1212 is suppressed The FAx1 and HAxp5 cells in the asap7sc7p5t_SIMPLE libraries have intentional CON->SN output-to-output timing arcs (mirror-adder topology, CON is reused internally by the sum stage). Explain this in liberty_suppressions.tcl so the arcs are not mistakenly removed from the Liberty files, and note that the suppression also hides STA-1212 for user-added libraries. Signed-off-by: dsengupta0628 --- flow/platforms/asap7/liberty_suppressions.tcl | 26 ++++++++++++++++--- 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/flow/platforms/asap7/liberty_suppressions.tcl b/flow/platforms/asap7/liberty_suppressions.tcl index c1526671c0..06c8902733 100644 --- a/flow/platforms/asap7/liberty_suppressions.tcl +++ b/flow/platforms/asap7/liberty_suppressions.tcl @@ -1,5 +1,23 @@ -# To remove [WARNING STA-1212] from the logs for ASAP7. -# /OpenROAD-flow-scripts/flow/platforms/asap7/lib/asap7sc7p5t_SIMPLE_RVT_TT_nldm_211120.lib.gz -# line 13178, timing group from output port. -# Added following suppress_message +# Suppress [WARNING STA-1212] "timing group from output port." for ASAP7. +# (This warning was numbered STA-0164 before OpenSTA renumbered its messages.) +# +# The asap7sc7p5t_SIMPLE_* libraries (all VT and corner variants) contain +# intentional output-to-output timing arcs from CON to SN in FAx1 and HAxp5. +# These cells use a mirror-adder topology: the inverted carry node (CON) is +# also an internal input to the sum stage, e.g. for HAxp5 +# SN = !((A + B) * CON). The CON->SN arcs model how CON's load delays SN. +# They are correct and must not be removed from the Liberty files. +# Removing them makes SN timing optimistic, because SN delay would no longer +# depend on CON's load. +# +# OpenSTA builds and uses these arcs whether or not the warning is +# suppressed, so this suppression only affects log output. +# +# Note that this applies to every Liberty file read in an ASAP7 flow, +# including user-added ones (e.g. ADDITIONAL_LIBS). Elsewhere, STA-1212 +# usually means a real library bug, such as a related_pin typo or wrong pin +# direction. +# +# See https://github.com/The-OpenROAD-Project/OpenROAD/discussions/3291 and +# https://github.com/The-OpenROAD-Project/OpenROAD-flow-scripts/pull/1056 suppress_message STA 1212