Skip to content

variables: retire MACRO_EXTENSION - #4633

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-macro-extension
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-macro-extension

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove MACRO_EXTENSION from variables.yaml; variables.json and FlowVariables.md regenerated.

Chesterton's Fence

  • Why it was put up: util.tcl passed it to set_macro_extension when setting up global routing.
  • Why it no longer stands: 41a62e3 ("remove macro extensions") deleted that call but left the variables.yaml entry. Nothing in ORFS reads the variable, so setting it silently does nothing.
  • Why it is safe to remove: behaviour is unchanged. Anyone who needs a macro extension can call set_macro_extension from FASTROUTE_TCL.

🤖 Generated with Claude Code

41a62e3 ("remove macro extensions") removed the only reader, the
set_macro_extension call in util.tcl, but left the variables.yaml
entry behind. Setting MACRO_EXTENSION has silently done nothing since.

Users who need a macro extension can call set_macro_extension from
FASTROUTE_TCL.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused MACRO_EXTENSION configuration variable from the documentation (FlowVariables.md) as well as the variables definition files (variables.json and variables.yaml). There are no review comments to address, and the changes look clean and complete.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit b8a98a9 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:55
@maliberty
maliberty merged commit e97f852 into The-OpenROAD-Project:master Oct 6, 2026
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants