Repository navigation
variables: retire MACRO_EXTENSION - #4633
Merged
maliberty merged 1 commit intoOct 6, 2026
Merged
Conversation
41a62e3 ("remove macro extensions") removed the only reader, the set_macro_extension call in util.tcl, but left the variables.yaml entry behind. Setting MACRO_EXTENSION has silently done nothing since. Users who need a macro extension can call set_macro_extension from FASTROUTE_TCL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused MACRO_EXTENSION configuration variable from the documentation (FlowVariables.md) as well as the variables definition files (variables.json and variables.yaml). There are no review comments to address, and the changes look clean and complete.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
MACRO_EXTENSIONfromvariables.yaml;variables.jsonandFlowVariables.mdregenerated.Chesterton's Fence
util.tclpassed it toset_macro_extensionwhen setting up global routing.variables.yamlentry. Nothing in ORFS reads the variable, so setting it silently does nothing.set_macro_extensionfromFASTROUTE_TCL.🤖 Generated with Claude Code