Skip to content

variables: retire SDC_GUT - #4634

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-sdc-gut
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-sdc-gut

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove SDC_GUT from variables.yaml; variables.json and FlowVariables.md regenerated.

Chesterton's Fence

  • Why it was put up: b4ce6f5 ("variables: flesh out some variables used in bazel-orfs") documented it as a way to gut a design before synthesis to mock SRAMs.
  • Why it no longer stands: no ORFS script or Makefile has ever read SDC_GUT (checked with git log -S). The gutting feature that exists is SYNTH_GUT.
  • Why it is safe to remove: the docs describe a feature that does not exist. SYNTH_GUT is unaffected.

🤖 Generated with Claude Code

SDC_GUT was documented in b4ce6f5 alongside variables used outside
ORFS, but no ORFS script or Makefile has ever read it. The gutting
feature that exists is SYNTH_GUT, which is unaffected.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the SDC_GUT flow variable from the documentation (FlowVariables.md) and the variables configuration files (variables.json and variables.yaml). I have no feedback to provide as there are no review comments.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 1c7991c · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:55
@maliberty
maliberty merged commit 781d3ca into The-OpenROAD-Project:master Oct 6, 2026
6 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants