Repository navigation
variables: retire CTS_SNAPSHOT - #4635
Merged
maliberty merged 1 commit intoOct 6, 2026
Merged
Conversation
9bf5cd7 introduced CTS snapshots: its commit message says CTS_SNAPSHOT=1, but the code reads CTS_SNAPSHOTS. CTS_SNAPSHOT is the misspelling from that message and has never been read. The "prior to clock net and setup/hold repair" snapshot it describes was removed in ad25dbe. CTS_SNAPSHOTS remains and is read by cts.tcl. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the unused CTS_SNAPSHOT variable and its associated documentation from FlowVariables.md, variables.json, and variables.yaml. There are no review comments to address, and I have no additional feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove
CTS_SNAPSHOTfromvariables.yaml;variables.jsonandFlowVariables.mdregenerated.Chesterton's Fence
make do-cts CTS_SNAPSHOT=1, but the code readsCTS_SNAPSHOTS, soCTS_SNAPSHOTis the misspelling from that message.CTS_SNAPSHOTSstays and is read bycts.tcl.🤖 Generated with Claude Code