Skip to content

variables: retire CTS_SNAPSHOT - #4635

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-cts-snapshot
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-cts-snapshot

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove CTS_SNAPSHOT from variables.yaml; variables.json and FlowVariables.md regenerated.

Chesterton's Fence

  • Why it was put up: 9bf5cd7 added CTS snapshots. Its commit message says make do-cts CTS_SNAPSHOT=1, but the code reads CTS_SNAPSHOTS, so CTS_SNAPSHOT is the misspelling from that message.
  • Why it no longer stands: it has never been read. The snapshot it describes ("prior to clock net and setup/hold repair") was removed in ad25dbe.
  • Why it is safe to remove: CTS_SNAPSHOTS stays and is read by cts.tcl.

🤖 Generated with Claude Code

9bf5cd7 introduced CTS snapshots: its commit message says
CTS_SNAPSHOT=1, but the code reads CTS_SNAPSHOTS. CTS_SNAPSHOT is the
misspelling from that message and has never been read.

The "prior to clock net and setup/hold repair" snapshot it describes
was removed in ad25dbe. CTS_SNAPSHOTS remains and is read by cts.tcl.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the unused CTS_SNAPSHOT variable and its associated documentation from FlowVariables.md, variables.json, and variables.yaml. There are no review comments to address, and I have no additional feedback to provide.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 9e0b8fa · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:56
@maliberty
maliberty merged commit d9d4fcf into The-OpenROAD-Project:master Oct 6, 2026
8 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants