Skip to content

variables: retire SKIP_ANTENNA_REPAIR_PRE_GRT - #4636

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-skip-antenna-repair-pre-grt
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-skip-antenna-repair-pre-grt

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove SKIP_ANTENNA_REPAIR_PRE_GRT from variables.yaml; variables.json and FlowVariables.md regenerated.

Chesterton's Fence

  • Why it was put up: 5cefa05 ("variables: add default values") added it to variables.yaml and the docs only.
  • Why it no longer stands: no script has ever read it. Pre-global-route antenna repair is controlled by SKIP_ANTENNA_REPAIR in global_route.tcl.
  • Why it is safe to remove: setting it silently did nothing, which misleads users into thinking repair is skipped. Behaviour is unchanged.

🤖 Generated with Claude Code

Added to variables.yaml in 5cefa05 ("variables: add default values")
without any script reading it. Pre-global-route antenna repair is
controlled by SKIP_ANTENNA_REPAIR in global_route.tcl, so setting this
variable silently did nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the SKIP_ANTENNA_REPAIR_PRE_GRT flow variable from the documentation (FlowVariables.md) and configuration files (variables.json and variables.yaml). I have no feedback to provide.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit d7a5472 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:55
@maliberty
maliberty merged commit ec74a3f into The-OpenROAD-Project:master Oct 6, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants