Skip to content

scripts: remove unused yosys.tcl - #4637

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-yosys-tcl
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-yosys-tcl

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove flow/scripts/yosys.tcl, which nothing references.

Chesterton's Fence

  • Why it was put up: a one-line wrapper, exec yosys $::env(SCRIPTS_DIR)/synth.tcl, so that synthesis could be started from inside an OpenROAD Tcl session.
  • Why it no longer stands: its only caller was run_all.tcl, the single-OpenROAD-invocation flow, which 0e02037 removed in 2023. Nothing in the repository sources it.
  • Why it is safe to remove: synthesis is started by synth.sh from flow/Makefile.

🤖 Generated with Claude Code

yosys.tcl execs yosys on synth.tcl. Its only caller was run_all.tcl,
the single-OpenROAD-invocation flow, which 0e02037 removed. Synthesis
is started from the Makefile and synth.sh, so nothing sources it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the execution of the Yosys synthesis script (synth.tcl). There are no review comments, and we have no feedback to provide.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit a6474b0 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:55
@maliberty
maliberty merged commit 1a84207 into The-OpenROAD-Project:master Oct 6, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants