Skip to content

scripts: remove unused add_routing_blk.tcl - #4638

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-add-routing-blk
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-add-routing-blk

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove flow/scripts/add_routing_blk.tcl, which nothing references.

Chesterton's Fence

  • Why it was put up: 6a7338d (2020) added routing blockages around macros for GF12 before global routing.
  • Why it no longer stands: its author removed the only call, from cts.tcl, three weeks later in 1166212 ("remove adding blockages over macros"). It has not been sourced since 2020.
  • Why it is safe to remove: no design, platform or script sources it, and behaviour is unchanged.

🤖 Generated with Claude Code

add_routing_blk.tcl (6a7338d) created routing blockages around macros
for GF12 before global routing. Its author removed the only call, from
cts.tcl, in 1166212 ("remove adding blockages over macros") three
weeks later, and nothing has sourced it since.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes the Tcl script file that was used to create routing blockages around macros for GF12. There are no review comments, so there is no feedback to provide.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit c30e5d6 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe

oharboe commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

@vvbandeira @maliberty Lots of CI outage this morning?

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:56
@maliberty
maliberty merged commit 8b1b51d into The-OpenROAD-Project:master Oct 6, 2026
9 of 12 checks passed
@vvbandeira

Copy link
Copy Markdown
Member

@vvbandeira @maliberty Lots of CI outage this morning?

Yes, but not on our end: https://www.githubstatus.com/history
image

@oharboe

oharboe commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

👍 These were very simple PRs to delete unused stuff, so I assigned it to Matt before they went green.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants