Skip to content

scripts: remove unused klayout.tcl - #4639

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-klayout-tcl
Oct 6, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
oharboe:retire-klayout-tcl

Conversation

@oharboe

@oharboe oharboe commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

Remove flow/scripts/klayout.tcl, which nothing references.

Chesterton's Fence

  • Why it was put up: it set fill_config and seal_gds from FILL_CONFIG/SEAL_GDS for a KLayout step.
  • Why it no longer stands: its only caller was run_all.tcl, the single-OpenROAD-invocation flow, which 0e02037 removed in 2023. Nothing in the repository sources it.
  • Why it is safe to remove: GDS merging runs through klayout.sh from flow/Makefile, which passes these settings itself.

🤖 Generated with Claude Code

klayout.tcl set up FILL_CONFIG and SEAL_GDS for a KLayout step. Its
only caller was run_all.tcl, the single-OpenROAD-invocation flow, which
0e02037 removed. GDS merging runs through klayout.sh from the
Makefile, so nothing sources it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a Tcl script that executed KLayout to convert a DEF file to a stream format using various environment variables. There are no review comments, and I have no feedback to provide.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit d7d8e8d · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@oharboe

oharboe commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator Author

@vvbandeira Why was lint CI cancelled?

@oharboe
oharboe requested a review from maliberty October 6, 2026 05:55
@maliberty
maliberty merged commit 0f76a43 into The-OpenROAD-Project:master Oct 6, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants