Repository navigation
Conversation
Ubuntu 22.04's Ruby 3.0 bundles net-imap 0.1.1 as a default gem. The flow never uses it, but CVE scanners flag it on downstream images. Remove the stale files at image build time. Fixes The-OpenROAD-Project#4376 Signed-off-by: noahwithoutark22 <yash.dubey.ece24@iitbhu.ac.in>
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies docker/Dockerfile.dev to remove an unused net-imap gem to address CVE scanner flags. The review feedback suggests chaining this cleanup command to the previous RUN instruction instead of running it in a separate layer, which prevents the deleted files from persisting in the final Docker image layers and optimizes the image size.
Address review feedback: a separate RUN leaves the gem in the earlier layer, so remove it in the same RUN as the dependency install. Signed-off-by: noahwithoutark22 <yash.dubey.ece24@iitbhu.ac.in>
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
noahwithoutark22
marked this pull request as ready for review
October 7, 2026 18:20
noahwithoutark22
requested review from
maliberty
and removed request for
a team
October 7, 2026 18:20
maliberty
approved these changes
Oct 8, 2026
maliberty
enabled auto-merge
October 8, 2026 20:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4376
Ubuntu 22.04's Ruby 3.0 ships
net-imap 0.1.1as a default gem. The flow never uses it, but CVE scanners flag it on downstream images. This removes the gem and its gemspec indocker/Dockerfile.dev, so images built on top of it inherit the fix. Thermuses globs, so it does nothing where the gem isn't present.Testing: on a minimal
ubuntu:22.04image withrubyinstalled, the gemspec is present before thermand gone afterwards, andrubystill runs. I haven't built the full dev image.Happy to switch to a base-image bump instead if you prefer.