Skip to content

fix(docker): remove unused net-imap default gem - #4644

Merged
maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
noahwithoutark22:fix/4376-remove-stale-net-imap
Oct 8, 2026
Merged

maliberty merged 2 commits into
The-OpenROAD-Project:masterfrom
noahwithoutark22:fix/4376-remove-stale-net-imap

Conversation

@noahwithoutark22

Copy link
Copy Markdown
Contributor

Fixes #4376

Ubuntu 22.04's Ruby 3.0 ships net-imap 0.1.1 as a default gem. The flow never uses it, but CVE scanners flag it on downstream images. This removes the gem and its gemspec in docker/Dockerfile.dev, so images built on top of it inherit the fix. The rm uses globs, so it does nothing where the gem isn't present.

Testing: on a minimal ubuntu:22.04 image with ruby installed, the gemspec is present before the rm and gone afterwards, and ruby still runs. I haven't built the full dev image.

Happy to switch to a base-image bump instead if you prefer.

Ubuntu 22.04's Ruby 3.0 bundles net-imap 0.1.1 as a default gem. The flow
never uses it, but CVE scanners flag it on downstream images. Remove the
stale files at image build time.

Fixes The-OpenROAD-Project#4376

Signed-off-by: noahwithoutark22 <yash.dubey.ece24@iitbhu.ac.in>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies docker/Dockerfile.dev to remove an unused net-imap gem to address CVE scanner flags. The review feedback suggests chaining this cleanup command to the previous RUN instruction instead of running it in a separate layer, which prevents the deleted files from persisting in the final Docker image layers and optimizes the image size.

Comment thread docker/Dockerfile.dev Resolved
Address review feedback: a separate RUN leaves the gem in the earlier
layer, so remove it in the same RUN as the dependency install.

Signed-off-by: noahwithoutark22 <yash.dubey.ece24@iitbhu.ac.in>
@openroad-ci

openroad-ci commented Oct 7, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 482b34e · Jenkins build #3 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@noahwithoutark22
noahwithoutark22 marked this pull request as ready for review October 7, 2026 18:20
@noahwithoutark22
noahwithoutark22 requested a review from a team as a code owner October 7, 2026 18:20
@noahwithoutark22
noahwithoutark22 requested review from maliberty and removed request for a team October 7, 2026 18:20
@maliberty
maliberty enabled auto-merge October 8, 2026 20:54
@maliberty
maliberty merged commit 2848820 into The-OpenROAD-Project:master Oct 8, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Enhancement] Remove/upgrade unused Ruby net-imap 0.1.1 from orfs Docker image (flagged by CVE scanners)

3 participants