Repository navigation
ci: remove the jenkins/public_tests_all.Jenkinsfile symlink - #4654
Merged
vvbandeira merged 1 commit intoOct 8, 2026
Merged
Conversation
The Jenkins jobs use the root Jenkinsfile as their script path. The symlink only pointed to that file. The symlink also broke builds of untrusted fork pull requests. For such a build, Jenkins reads the pipeline script from the base branch through the git plugin. The git plugin returns the link text "../Jenkinsfile" and does not follow the link, so the script does not compile. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
vvbandeira
merged commit Oct 8, 2026
f395e4b
into
The-OpenROAD-Project:master
10 of 12 checks passed
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes
jenkins/public_tests_all.Jenkinsfile, a symlink to the rootJenkinsfile.The Jenkins jobs that used this path now use the root
Jenkinsfileas their script path, so the link is unused.The root
Jenkinsfiledoes not change.The link also broke builds of fork pull requests that Jenkins does not trust.
For such a build, Jenkins loads the pipeline script from the base branch through the git plugin, which returns the link text
../Jenkinsfileand does not follow the link.The build then failed with
WorkflowScript: 1: unexpected token: .. @ line 1, column 1.Plugin source, at the versions installed on jenkins.openroad.tools: