Skip to content

ci: remove the jenkins/public_tests_all.Jenkinsfile symlink - #4654

Merged
vvbandeira merged 1 commit into
The-OpenROAD-Project:masterfrom
vvbandeira:jenkinsfile-no-symlink
Oct 8, 2026
Merged

vvbandeira merged 1 commit into
The-OpenROAD-Project:masterfrom
vvbandeira:jenkinsfile-no-symlink

Conversation

@vvbandeira

Copy link
Copy Markdown
Member

This PR removes jenkins/public_tests_all.Jenkinsfile, a symlink to the root Jenkinsfile.
The Jenkins jobs that used this path now use the root Jenkinsfile as their script path, so the link is unused.
The root Jenkinsfile does not change.

The link also broke builds of fork pull requests that Jenkins does not trust.
For such a build, Jenkins loads the pipeline script from the base branch through the git plugin, which returns the link text ../Jenkinsfile and does not follow the link.
The build then failed with WorkflowScript: 1: unexpected token: .. @ line 1, column 1.

Plugin source, at the versions installed on jenkins.openroad.tools:

The Jenkins jobs use the root Jenkinsfile as their script path. The
symlink only pointed to that file.

The symlink also broke builds of untrusted fork pull requests. For such
a build, Jenkins reads the pipeline script from the base branch through
the git plugin. The git plugin returns the link text "../Jenkinsfile"
and does not follow the link, so the script does not compile.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
@vvbandeira
vvbandeira requested a review from a team as a code owner October 8, 2026 18:18
@vvbandeira
vvbandeira requested review from sombraSoft and removed request for a team October 8, 2026 18:18

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a file containing a reference to the Jenkinsfile. There are no review comments, and I have no feedback to provide.

@vvbandeira
vvbandeira merged commit f395e4b into The-OpenROAD-Project:master Oct 8, 2026
10 of 12 checks passed
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit de52868 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@vvbandeira
vvbandeira deleted the jenkinsfile-no-symlink branch October 9, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants