Repository navigation
Conversation
eder-matheus
commented
Oct 13, 2026
Member
| gf12/jpeg (finish) | master (500 ps) | this branch (460 ps) |
|---|---|---|
| WNS (ps) | +7.56 | -35.63 |
| TNS (ps) | 0 | -9100.56 |
| Violating endpoints | 0 | 560 |
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request reduces the clock period constraint for the JPEG encoder design from 500 to 460. However, this change introduces a negative Worst Negative Slack (WNS) and multiple violating endpoints, which causes the design to fail timing closure. It is recommended to adjust the clock period to a value that ensures non-negative slack unless this negative slack is explicitly intended.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.