Skip to content

gf12/jpeg: tighten clock period from 500 to 460 so ws < 0 - #4673

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_gf12_jpeg
Oct 14, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:update_gf12_jpeg

Conversation

@eder-matheus

Copy link
Copy Markdown
Member
gf12/jpeg (finish) master (500 ps) this branch (460 ps)
WNS (ps) +7.56 -35.63
TNS (ps) 0 -9100.56
Violating endpoints 0 560

Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
@eder-matheus eder-matheus self-assigned this Oct 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces the clock period constraint for the JPEG encoder design from 500 to 460. However, this change introduces a negative Worst Negative Slack (WNS) and multiple violating endpoints, which causes the design to fail timing closure. It is recommended to adjust the clock period to a value that ensures non-negative slack unless this negative slack is explicitly intended.

Comment thread flow/designs/gf12/jpeg/constraint.sdc Resolved
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 79f3f4c · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty
maliberty merged commit 1d1b487 into The-OpenROAD-Project:master Oct 14, 2026
12 checks passed
@maliberty
maliberty deleted the update_gf12_jpeg branch October 14, 2026 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants