Repository navigation
Update the IHP PDK - #4684
Update the IHP PDK#4684maliberty merged 1 commit into
Conversation
Gets footprint fixes from upstream. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the I/O and memory library files for the ihp-sg13g2 platform, including CDL, LEF, LIB, LYP/LYT, Verilog, and layout properties. Key changes include restructuring subcircuits, adjusting filler dimensions, adding simulation-only checks in Verilog, and updating capacitance values. The review feedback highlights critical issues in the CDL file: the removal of global substrate declarations (sub!) which will cause LVS mismatches, a missing micrometer unit (u) in a perimeter parameter, and an incorrectly tied PMOS transistor (MP0) in the level-down circuit that disables it and leaves a node floating.
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 3 with regression(s), 0 without a comparable baseline. ❌ ihp-sg13g2/jpeg base — 4 failing metric(s)
❌ ihp-sg13g2/riscv32i base — 2 failing metric(s)
❌ ihp-sg13g2/spi base — 1 failing metric(s)
|
3ed9783
into
The-OpenROAD-Project:master
Gets footprint fixes from upstream.