Skip to content

Update the IHP PDK - #4684

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:ihp-update
Oct 16, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:ihp-update

Conversation

@maliberty

Copy link
Copy Markdown
Member

Gets footprint fixes from upstream.

Gets footprint fixes from upstream.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Oct 16, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-16T00:20:23.656255Z 074574c PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the I/O and memory library files for the ihp-sg13g2 platform, including CDL, LEF, LIB, LYP/LYT, Verilog, and layout properties. Key changes include restructuring subcircuits, adjusting filler dimensions, adding simulation-only checks in Verilog, and updating capacitance values. The review feedback highlights critical issues in the CDL file: the removal of global substrate declarations (sub!) which will cause LVS mismatches, a missing micrometer unit (u) in a perimeter parameter, and an incorrectly tied PMOS transistor (MP0) in the level-down circuit that disables it and leaves a node floating.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 0bf0cb8 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 3 with regression(s), 0 without a comparable baseline.

❌ ihp-sg13g2/jpeg base — 4 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -82.360 -37.169 -121.585% -44.602 PeriodPadding 20.000%
detailedroute__antenna_diodes_count 109.000 99.000 10.101% 100.000 Metric 0.100%
finish__timing__setup__tns -23.449 -12.707 -84.536% -15.248 PeriodPadding 20.000%
globalroute__timing__setup__tns -124.055 -69.023 -79.729% -82.828 PeriodPadding 20.000%
❌ ihp-sg13g2/riscv32i base — 2 failing metric(s)
Metric target base delta limit band
finish__timing__setup__ws -2.002 -1.847 -8.399% -1.947 PeriodPadding 5.000%
globalroute__timing__setup__ws -2.068 -1.926 -7.370% -2.026 PeriodPadding 5.000%
❌ ihp-sg13g2/spi base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -0.666 -0.328 -102.906% -0.488 PeriodPadding 20.000%

@maliberty
maliberty merged commit 3ed9783 into The-OpenROAD-Project:master Oct 16, 2026
10 of 12 checks passed
@maliberty
maliberty deleted the ihp-update branch October 16, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants