Skip to content

installer: default to Bazel and pass -cmake to the OpenROAD installer - #4686

Closed
vvbandeira wants to merge 3 commits into
The-OpenROAD-Project:masterfrom
vvbandeira:installer-bazel-default
Closed

vvbandeira wants to merge 3 commits into
The-OpenROAD-Project:masterfrom
vvbandeira:installer-bazel-default

Conversation

@vvbandeira

Copy link
Copy Markdown
Member

OpenROAD #11634 made its DependencyInstaller.sh default to Bazel.
Its -base and -common now install the CMake package set only with -cmake.
The ORFS installer passes -base -bazel without -cmake.
So the OpenROAD -base installs only the Bazel runtime libraries, and it does not install wget.
The ORFS KLayout download then fails with wget: command not found when it builds the dev image.

Changes

  • Add -bazel and -cmake flags to the ORFS installer. -bazel is the default, so current callers get the same result. -cmake skips the Bazel set. If you give both flags, the last one wins.
  • Always pass -cmake to the OpenROAD installer. Yosys, EQY and kepler-formal need the CMake set with both build systems, and the set also has wget.
  • For a Bazel build, run a bare -bazel call in the privileged step, so that bazelisk goes to /usr/local. The -common prefix is not on PATH.
  • Move tools/OpenROAD to 61470341f3. This version has the -cmake option.

Checks

  • bash -n on the changed scripts, and a stub run of the ORFS installer with 12 flag combinations.
  • In a clean ubuntu:22.04 container, the OpenROAD installer with -eqy ... -base -bazel installs no wget. With -eqy ... -cmake -base, /usr/bin/wget is present.
  • I did not run a full Dockerfile.dev build locally. The dev image tag changes, because DockerTag.sh hashes the OpenROAD installer.

The installer always gave -bazel to the OpenROAD installer with -base
or -all. There was no flag to skip it. Users who build OpenROAD with
CMake (build_openroad.sh --openroad-args -cmake-build) do not need
bazelisk and its runtime libraries.

-bazel is the default, so current callers get the same result. -cmake
skips Bazel. If both flags are given, the last one wins.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
The OpenROAD installer now defaults to the Bazel set. Its -base and
-common install the CMake set only with -cmake. Yosys, EQY and
kepler-formal need the CMake set for both build systems, so always pass
-cmake.

With -bazel, -base now installs only the Bazel runtime libraries, and
-common installs bazelisk into the -common prefix. That prefix is not on
PATH. A separate bare -bazel call in the privileged step keeps bazelisk
in /usr/local. The installed parts stay the same for -base, -common and
-all, with or without -ci.

This needs the OpenROAD submodule at a version with the -cmake option.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Move tools/OpenROAD to 61470341f3. It includes the OpenROAD
installer that defaults to Bazel and takes -cmake, and the Build.sh
that builds with Bazel by default. The ORFS installer passes -cmake,
so it needs this version.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
@vvbandeira
vvbandeira marked this pull request as ready for review October 16, 2026 03:26
@vvbandeira
vvbandeira requested a review from a team as a code owner October 16, 2026 03:26
@vvbandeira
vvbandeira requested review from sombraSoft and removed request for a team October 16, 2026 03:26

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates etc/DependencyInstaller.sh to support installing dependencies for either Bazel or CMake build systems, defaulting to Bazel, and updates the tools/OpenROAD submodule. A critical issue was identified where calling the OpenROAD DependencyInstaller.sh with only -bazel and no option flag (such as -base or -all) will cause it to fail or do nothing; passing the corresponding option flag is recommended.

Comment on lines +37 to +39
if [[ "${buildSystem}" == "bazel" ]] && [[ "${option}" == "base" || "${option}" == "all" ]]; then
./tools/OpenROAD/etc/DependencyInstaller.sh -bazel
fi

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Calling the OpenROAD DependencyInstaller.sh with only -bazel and no option flag (such as -base or -all) will cause it to fail or do nothing, because the installer requires an option to be specified. Since we are already inside a block that guards for option being base or all, we should pass the corresponding option flag to the second installer call.

Suggested change
if [[ "${buildSystem}" == "bazel" ]] && [[ "${option}" == "base" || "${option}" == "all" ]]; then
./tools/OpenROAD/etc/DependencyInstaller.sh -bazel
fi
if [[ "${buildSystem}" == "bazel" ]] && [[ "${option}" == "base" || "${option}" == "all" ]]; then
./tools/OpenROAD/etc/DependencyInstaller.sh -bazel -${option}
fi

@vvbandeira vvbandeira closed this Oct 16, 2026
@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit a66d3b7 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 14 with regression(s), 0 without a comparable baseline.

❌ asap7/riscv32i base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -9426.610 -960.116 -881.820% -1152.139 PeriodPadding 20.000%
❌ asap7/swerv_wrapper base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -3130.530 -1551.920 -101.720% -1862.304 PeriodPadding 20.000%
❌ gf180/jpeg base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -27.246 -0.0220 -123953.307% -1.222 PeriodPadding 20.000%
❌ ihp-sg13g2/ibex base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -17.440 -1.297 -1244.740% -2.897 PeriodPadding 20.000%
❌ ihp-sg13g2/jpeg base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -82.360 -37.169 -121.585% -44.602 PeriodPadding 20.000%
detailedroute__antenna_diodes_count 129.000 99.000 30.303% 100.000 Metric 0.100%
finish__timing__setup__tns -15.645 -12.707 -23.125% -15.248 PeriodPadding 20.000%
❌ ihp-sg13g2/spi base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -0.666 -0.328 -102.906% -0.488 PeriodPadding 20.000%
❌ nangate45/ariane133 base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -448.866 -315.386 -42.323% -378.463 PeriodPadding 20.000%
finish__timing__setup__tns -460.744 -292.142 -57.712% -350.570 PeriodPadding 20.000%
globalroute__timing__setup__tns -446.739 -369.105 -21.033% -442.926 PeriodPadding 20.000%
❌ nangate45/bp_be_top base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -1.514 0.000 — -0.520 PeriodPadding 20.000%
❌ nangate45/ibex base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -14.938 -2.698 -453.740% -3.237 PeriodPadding 20.000%
❌ sky130hd/aes base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -3.930 -0.492 -699.506% -1.212 PeriodPadding 20.000%
❌ sky130hd/chameleon base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -16.627 -12.678 -31.146% -15.214 PeriodPadding 20.000%
detailedroute__antenna_diodes_count 165.000 114.000 44.737% 114.114 Metric 0.100%
finish__timing__setup__tns -19.852 -8.719 -127.679% -10.463 PeriodPadding 20.000%
❌ sky130hd/microwatt base — 3 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -258.337 -213.433 -21.039% -256.120 PeriodPadding 20.000%
detailedroute__antenna_diodes_count 1639.000 1457.000 12.491% 1458.457 Metric 0.100%
finish__timing__setup__tns -228.158 -165.245 -38.073% -198.294 PeriodPadding 20.000%
❌ sky130hd/riscv32i base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -54.264 -41.992 -29.225% -50.391 PeriodPadding 20.000%
❌ sky130hs/aes base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -1.433 -0.0291 -4828.949% -0.589 PeriodPadding 20.000%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants