Repository navigation
installer: default to Bazel and pass -cmake to the OpenROAD installer - #4686
vvbandeira wants to merge 3 commits into
Conversation
The installer always gave -bazel to the OpenROAD installer with -base or -all. There was no flag to skip it. Users who build OpenROAD with CMake (build_openroad.sh --openroad-args -cmake-build) do not need bazelisk and its runtime libraries. -bazel is the default, so current callers get the same result. -cmake skips Bazel. If both flags are given, the last one wins. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
The OpenROAD installer now defaults to the Bazel set. Its -base and -common install the CMake set only with -cmake. Yosys, EQY and kepler-formal need the CMake set for both build systems, so always pass -cmake. With -bazel, -base now installs only the Bazel runtime libraries, and -common installs bazelisk into the -common prefix. That prefix is not on PATH. A separate bare -bazel call in the privileged step keeps bazelisk in /usr/local. The installed parts stay the same for -base, -common and -all, with or without -ci. This needs the OpenROAD submodule at a version with the -cmake option. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Move tools/OpenROAD to 61470341f3. It includes the OpenROAD installer that defaults to Bazel and takes -cmake, and the Build.sh that builds with Bazel by default. The ORFS installer passes -cmake, so it needs this version. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
There was a problem hiding this comment.
Code Review
This pull request updates etc/DependencyInstaller.sh to support installing dependencies for either Bazel or CMake build systems, defaulting to Bazel, and updates the tools/OpenROAD submodule. A critical issue was identified where calling the OpenROAD DependencyInstaller.sh with only -bazel and no option flag (such as -base or -all) will cause it to fail or do nothing; passing the corresponding option flag is recommended.
| if [[ "${buildSystem}" == "bazel" ]] && [[ "${option}" == "base" || "${option}" == "all" ]]; then | ||
| ./tools/OpenROAD/etc/DependencyInstaller.sh -bazel | ||
| fi |
There was a problem hiding this comment.
Calling the OpenROAD DependencyInstaller.sh with only -bazel and no option flag (such as -base or -all) will cause it to fail or do nothing, because the installer requires an option to be specified. Since we are already inside a block that guards for option being base or all, we should pass the corresponding option flag to the second installer call.
| if [[ "${buildSystem}" == "bazel" ]] && [[ "${option}" == "base" || "${option}" == "all" ]]; then | |
| ./tools/OpenROAD/etc/DependencyInstaller.sh -bazel | |
| fi | |
| if [[ "${buildSystem}" == "bazel" ]] && [[ "${option}" == "base" || "${option}" == "all" ]]; then | |
| ./tools/OpenROAD/etc/DependencyInstaller.sh -bazel -${option} | |
| fi |
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 14 with regression(s), 0 without a comparable baseline. ❌ asap7/riscv32i base — 1 failing metric(s)
❌ asap7/swerv_wrapper base — 1 failing metric(s)
❌ gf180/jpeg base — 1 failing metric(s)
❌ ihp-sg13g2/ibex base — 1 failing metric(s)
❌ ihp-sg13g2/jpeg base — 3 failing metric(s)
❌ ihp-sg13g2/spi base — 1 failing metric(s)
❌ nangate45/ariane133 base — 3 failing metric(s)
❌ nangate45/bp_be_top base — 1 failing metric(s)
❌ nangate45/ibex base — 1 failing metric(s)
❌ sky130hd/aes base — 1 failing metric(s)
❌ sky130hd/chameleon base — 3 failing metric(s)
❌ sky130hd/microwatt base — 3 failing metric(s)
❌ sky130hd/riscv32i base — 1 failing metric(s)
❌ sky130hs/aes base — 1 failing metric(s)
|
OpenROAD #11634 made its
DependencyInstaller.shdefault to Bazel.Its
-baseand-commonnow install the CMake package set only with-cmake.The ORFS installer passes
-base -bazelwithout-cmake.So the OpenROAD
-baseinstalls only the Bazel runtime libraries, and it does not installwget.The ORFS KLayout download then fails with
wget: command not foundwhen it builds the dev image.Changes
-bazeland-cmakeflags to the ORFS installer.-bazelis the default, so current callers get the same result.-cmakeskips the Bazel set. If you give both flags, the last one wins.-cmaketo the OpenROAD installer. Yosys, EQY and kepler-formal need the CMake set with both build systems, and the set also haswget.-bazelcall in the privileged step, so that bazelisk goes to/usr/local. The-commonprefix is not onPATH.tools/OpenROADto61470341f3. This version has the-cmakeoption.Checks
bash -non the changed scripts, and a stub run of the ORFS installer with 12 flag combinations.ubuntu:22.04container, the OpenROAD installer with-eqy ... -base -bazelinstalls nowget. With-eqy ... -cmake -base,/usr/bin/wgetis present.Dockerfile.devbuild locally. The dev image tag changes, becauseDockerTag.shhashes the OpenROAD installer.