Skip to content

fix(deps): install ORFS's Ubuntu deps instead of OpenROAD's CMake set - #4687

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:deps-own-cmake-set
Oct 16, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:deps-own-cmake-set

Conversation

@maliberty

@maliberty maliberty commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

Problem

Nightly #7633 failed to build the dev image on both Ubuntu 22.04 and 24.04:

./DependencyInstaller.sh: line 272: wget: command not found

OpenROAD master now includes The-OpenROAD-Project/OpenROAD#11634, which makes its DependencyInstaller.sh default to the Bazel dependency set. Without -cmake, -base installs only the Bazel runtime libraries, and -common only installs bazelisk. ORFS never passed -cmake, but it relied on that set without listing it: wget for the KLayout download, CMake ≥ 3.28 to build yosys, gmock for yosys's unit tests, and so on.

Fix

ORFS now installs what it uses itself, rather than adding -cmake back and pulling OpenROAD's whole CMake set (boost, or-tools, swig, eqy, ...):

  • Ubuntu -base: build-essential, ca-certificates, git, libffi-dev, libgmock-dev, python3-dev, tcl-dev, tcllib, unzip, wget.
  • Ubuntu -common: fetch CMake 3.31.9 from Kitware (checksummed) when the CMake on PATH is older than 3.28. Honors -prefix and -local.
  • -ci: jq, parallel, zip, gnupg, lsb-release.
  • Drop the default -eqy. The flow doesn't use eqy or sby, and OpenROAD now ignores it without -cmake, with a warning.

The new version check uses sort -V, because the existing _versionCompare gives the wrong answer when the two versions have different numbers of components (it says 3.22.1 ≥ 3.28).

This PR only covers Ubuntu, the only platform ORFS CI builds. EL and macOS are left as they were, and they now lack the same OpenROAD-provided packages.

Testing

Tested against OpenROAD master 835f9daa, the revision the failing nightly used. I built the dev image with docker/Dockerfile.dev and -ci, exactly as the nightly does, then built yosys and kepler-formal inside it using the CMake commands from build_openroad.sh.

Platform Dev image yosys kepler-formal
Ubuntu 22.04 ✅ ✅ ✅
Ubuntu 24.04 ✅ ✅ ✅

@maliberty maliberty self-assigned this Oct 16, 2026
@maliberty
maliberty requested a review from a team as a code owner October 16, 2026 03:59
@maliberty
maliberty requested review from vvbandeira and removed request for a team October 16, 2026 03:59
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T04:07:26.786618Z c1cd5fc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the DependencyInstaller.sh script to support building and installing newer versions of CMake and Bison when system-provided versions are outdated. It also updates package dependencies for Enterprise Linux (EL8/EL9), Ubuntu, macOS, and CI environments, and configures Python 3.12 on EL8. The review feedback identifies several critical issues: potential script crashes on EL8/EL9 due to repository casing differences in dnf config-manager, a failure to register the new Python alternative on EL8 before setting it, and potential leftover temporary directories if commands fail inside subshells during CMake and Bison installations.

Comment thread etc/DependencyInstaller.sh Resolved
Comment thread etc/DependencyInstaller.sh Resolved
Comment thread etc/DependencyInstaller.sh Resolved
Comment thread etc/DependencyInstaller.sh Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c1cd5fc70a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread etc/DependencyInstaller.sh Resolved
OpenROAD's DependencyInstaller.sh now defaults to the Bazel dependency
set (OpenROAD #11634). Without -cmake it no longer installs the CMake
base packages or builds CMake and googletest in -common. ORFS relied on
that set without listing it, so the nightly dev image fails with
"wget: command not found" when fetching KLayout.

Install what ORFS needs itself rather than pulling the whole CMake set:

- Ubuntu -base: build-essential, ca-certificates, git, libffi-dev,
  libgmock-dev (yosys unit tests), python3-dev, tcl-dev, tcllib, unzip,
  wget.
- Ubuntu -common: fetch CMake 3.31.9 from Kitware when the CMake on
  PATH is older than 3.28 (yosys's minimum). Honors -prefix and -local.
- -ci: jq, parallel, zip, gnupg, lsb-release.

Drop the default -eqy: the flow does not use eqy or sby, and OpenROAD
now ignores it without -cmake.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty changed the title fix(deps): install ORFS's own deps instead of OpenROAD's CMake set fix(deps): install ORFS's Ubuntu deps instead of OpenROAD's CMake set Oct 16, 2026
@maliberty
maliberty merged commit 8b5e62f into The-OpenROAD-Project:master Oct 16, 2026
10 of 12 checks passed
@maliberty
maliberty deleted the deps-own-cmake-set branch October 16, 2026 05:20
@maliberty

Copy link
Copy Markdown
Member Author

@vvbandeira I merged once I saw that compilation of all binaries passed in order to get master passing. If you have any comments I'm glad to do a follow up PR.

@openroad-ci

openroad-ci commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 6d28d9f · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants