Repository navigation
fix(deps): install ORFS's Ubuntu deps instead of OpenROAD's CMake set - #4687
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the DependencyInstaller.sh script to support building and installing newer versions of CMake and Bison when system-provided versions are outdated. It also updates package dependencies for Enterprise Linux (EL8/EL9), Ubuntu, macOS, and CI environments, and configures Python 3.12 on EL8. The review feedback identifies several critical issues: potential script crashes on EL8/EL9 due to repository casing differences in dnf config-manager, a failure to register the new Python alternative on EL8 before setting it, and potential leftover temporary directories if commands fail inside subshells during CMake and Bison installations.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1cd5fc70a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
OpenROAD's DependencyInstaller.sh now defaults to the Bazel dependency set (OpenROAD #11634). Without -cmake it no longer installs the CMake base packages or builds CMake and googletest in -common. ORFS relied on that set without listing it, so the nightly dev image fails with "wget: command not found" when fetching KLayout. Install what ORFS needs itself rather than pulling the whole CMake set: - Ubuntu -base: build-essential, ca-certificates, git, libffi-dev, libgmock-dev (yosys unit tests), python3-dev, tcl-dev, tcllib, unzip, wget. - Ubuntu -common: fetch CMake 3.31.9 from Kitware when the CMake on PATH is older than 3.28 (yosys's minimum). Honors -prefix and -local. - -ci: jq, parallel, zip, gnupg, lsb-release. Drop the default -eqy: the flow does not use eqy or sby, and OpenROAD now ignores it without -cmake. Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
c1cd5fc to
d67d822
Compare
8b5e62f
into
The-OpenROAD-Project:master
|
@vvbandeira I merged once I saw that compilation of all binaries passed in order to get master passing. If you have any comments I'm glad to do a follow up PR. |
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
Problem
Nightly #7633 failed to build the dev image on both Ubuntu 22.04 and 24.04:
OpenROAD master now includes The-OpenROAD-Project/OpenROAD#11634, which makes its
DependencyInstaller.shdefault to the Bazel dependency set. Without-cmake,-baseinstalls only the Bazel runtime libraries, and-commononly installs bazelisk. ORFS never passed-cmake, but it relied on that set without listing it:wgetfor the KLayout download, CMake ≥ 3.28 to build yosys, gmock for yosys's unit tests, and so on.Fix
ORFS now installs what it uses itself, rather than adding
-cmakeback and pulling OpenROAD's whole CMake set (boost, or-tools, swig, eqy, ...):-base: build-essential, ca-certificates, git, libffi-dev, libgmock-dev, python3-dev, tcl-dev, tcllib, unzip, wget.-common: fetch CMake 3.31.9 from Kitware (checksummed) when the CMake on PATH is older than 3.28. Honors-prefixand-local.-ci: jq, parallel, zip, gnupg, lsb-release.-eqy. The flow doesn't use eqy or sby, and OpenROAD now ignores it without-cmake, with a warning.The new version check uses
sort -V, because the existing_versionComparegives the wrong answer when the two versions have different numbers of components (it says 3.22.1 ≥ 3.28).This PR only covers Ubuntu, the only platform ORFS CI builds. EL and macOS are left as they were, and they now lack the same OpenROAD-provided packages.
Testing
Tested against OpenROAD master 835f9daa, the revision the failing nightly used. I built the dev image with
docker/Dockerfile.devand-ci, exactly as the nightly does, then built yosys and kepler-formal inside it using the CMake commands frombuild_openroad.sh.