Skip to content

Add SKIP_FLOORPLAN_REPAIR_TIMING - #4715

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:skip-floorplan-repair-timing
Oct 22, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:skip-floorplan-repair-timing

Conversation

@maliberty

Copy link
Copy Markdown
Member

The previous REMOVE_ABC_BUFFERS had this as a side-effect. Sometimes the autotuner found to be useful. This restore the possibilty.

@maliberty maliberty self-assigned this Oct 21, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-21T23:24:52.797431Z d755771 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d75577139a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread flow/scripts/variables.yaml Resolved
Comment thread flow/scripts/variables.yaml Resolved

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new environment variable SKIP_FLOORPLAN_REPAIR_TIMING to allow skipping the floorplan repair timing step, updating the TCL script, JSON, and YAML configuration files. Feedback suggests using the env_var_equals helper function instead of directly dereferencing $::env(SKIP_FLOORPLAN_REPAIR_TIMING) to prevent potential crashes if the environment variable is undefined.

Comment thread flow/scripts/floorplan.tcl Resolved
The previous REMOVE_ABC_BUFFERS had this as a side-effect.  Sometimes
the autotuner found to be useful.  This restore the possibilty.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@openroad-ci
openroad-ci force-pushed the skip-floorplan-repair-timing branch from d755771 to e1cc60e Compare October 21, 2026 23:56
@openroad-ci

openroad-ci commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit e76aa55 · Jenkins build #2 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty
maliberty merged commit 52a3c21 into The-OpenROAD-Project:master Oct 22, 2026
12 checks passed
@maliberty
maliberty deleted the skip-floorplan-repair-timing branch October 22, 2026 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants