Repository navigation
scripts: save the final images with the web viewer by default #4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jorge-ferreira-pii
wants to merge
6
commits into
The-OpenROAD-Project:master
Choose a base branch
from
The-OpenROAD-Project-staging:issue11488-orfs-2-save-images-web-default
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8a17646
scripts: SAVE_IMAGES_VIEWER picks the viewer for the final images
jorge-ferreira-pii 715b96b
scripts: save the final images with the web viewer by default
jorge-ferreira-pii 9c1a877
scripts: SAVE_IMAGES_VIEWER picks the viewer for the final images
jorge-ferreira-pii a701f6a
scripts: read SAVE_IMAGES_VIEWER as the Makefile contract asks
jorge-ferreira-pii 8d5c9bf
Merge branch 'issue11488-orfs-1-save-images-viewer' into issue11488-o…
jorge-ferreira-pii 3197d05
scripts: SAVE_IMAGES_VIEWER follow-ups from review
jorge-ferreira-pii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,14 @@ | ||
| source $::env(SCRIPTS_DIR)/util.tcl | ||
|
|
||
| # With no Qt window up, the web viewer draws the images; it writes only PNG. | ||
| if { [gui::has_ui] } { | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
| set web_flag {} | ||
| set ext webp | ||
| } else { | ||
| set web_flag -web | ||
| set ext png | ||
| } | ||
|
|
||
| gui::save_display_controls | ||
|
|
||
| set height [[[ord::get_db_block] getBBox] getDY] | ||
|
|
@@ -30,22 +39,22 @@ gui::set_display_controls "Misc/Highlight selected" visible true | |
| gui::set_display_controls "Misc/Detailed view" visible true | ||
|
|
||
| # The routing view | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_all.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_all.$ext | ||
| gui::set_display_controls "Nets/Power" visible false | ||
| gui::set_display_controls "Nets/Ground" visible false | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_routing.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_routing.$ext | ||
|
|
||
| # The placement view without routing | ||
| gui::set_display_controls "Shape Types/Routing/*" visible false | ||
| gui::set_display_controls "Instances/Physical/Fill cell" visible false | ||
| gui::set_display_controls "Misc/Instances/*" visible false | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_placement.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_placement.$ext | ||
|
|
||
| if { [env_var_exists_and_non_empty PWR_NETS_VOLTAGES] } { | ||
| gui::set_display_controls "Heat Maps/IR Drop" visible true | ||
| gui::set_heatmap IRDrop Layer $::env(IR_DROP_LAYER) | ||
| gui::set_heatmap IRDrop ShowLegend 1 | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_ir_drop.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_ir_drop.$ext | ||
| gui::set_display_controls "Heat Maps/IR Drop" visible false | ||
| } | ||
|
|
||
|
|
@@ -58,7 +67,7 @@ gui::set_display_controls "Instances/StdCells/Clock tree/*" visible true | |
| gui::set_display_controls "Instances/StdCells/Sequential" visible true | ||
| gui::set_display_controls "Instances/Macro" visible true | ||
| select -name "clk*" -type Inst | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_clocks.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_clocks.$ext | ||
| gui::clear_selections | ||
|
|
||
| gui::show_widget "Clock Tree Viewer" | ||
|
|
@@ -70,10 +79,10 @@ foreach scene [get_scenes] { | |
| save_clocktree_image -clock $clock_name \ | ||
| -width 1024 -height 1024 \ | ||
| -scene $scene \ | ||
| $::env(REPORTS_DIR)/cts_${scene_name}_${clock_name}.webp | ||
| $::env(REPORTS_DIR)/cts_${scene_name}_${clock_name}.$ext | ||
| gui::select_clockviewer_clock $clock_name | ||
| save_image -resolution $resolution \ | ||
| $::env(REPORTS_DIR)/cts_${scene_name}_${clock_name}_layout.webp | ||
| save_image {*}$web_flag -resolution $resolution \ | ||
| $::env(REPORTS_DIR)/cts_${scene_name}_${clock_name}_layout.$ext | ||
| } | ||
| } | ||
| } | ||
|
|
@@ -98,7 +107,7 @@ select -name "wire*" -type Inst -highlight 3 | |
| select -name "rebuffer*" -type Inst -highlight 4 ;# red | ||
| select -name "split*" -type Inst -highlight 5 ;# dark green | ||
|
|
||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_resizer.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_resizer.$ext | ||
|
|
||
| gui::clear_highlights -1 | ||
| gui::clear_selections | ||
|
|
@@ -109,7 +118,7 @@ gui::set_display_controls "Instances/Physical/*" visible false | |
| gui::set_display_controls "Nets/*" visible false | ||
| gui::set_display_controls "Heat Maps/Routing Congestion" visible true | ||
|
|
||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_congestion.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_congestion.$ext | ||
|
|
||
| # The worst timing path view | ||
| gui::set_display_controls "Heat Maps/Routing Congestion" visible false | ||
|
|
@@ -119,7 +128,7 @@ gui::set_display_controls "Instances/*" visible true | |
| gui::set_display_controls "Shape Types/Routing/*" visible false | ||
|
|
||
| gui::show_worst_path | ||
| save_image -resolution $resolution $::env(REPORTS_DIR)/final_worst_path.webp | ||
| save_image {*}$web_flag -resolution $resolution $::env(REPORTS_DIR)/final_worst_path.$ext | ||
| gui::set_display_controls "Timing Path/*" visible false | ||
|
|
||
| gui::restore_display_controls | ||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The file
final_all.pngis listed in thereportsdirectory table above but is missing from this description table. Please add a description forfinal_all.pngto keep the documentation complete and consistent.