Skip to content

asap7: keep the PDN macro halo inside the row halo - #4725

Merged
maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:asap7-pdn-macro-halo
Oct 24, 2026
Merged

maliberty merged 1 commit into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:asap7-pdn-macro-halo

Conversation

@maliberty

Copy link
Copy Markdown
Member

Problem

asap7/swerv_wrapper fails in 2_4_floorplan_pdn:

[WARNING PDN-0178] Remaining channel (208.8180, 72.0330) - (214.8120, 77.7210) on M2 for nets: VDD
[WARNING PDN-0178] Remaining channel (227.7720, 72.0330) - (237.4920, 77.7210) on M2 for nets: VDD
[WARNING PDN-0178] Remaining channel (269.4060, 72.0330) - (275.4000, 77.7210) on M2 for nets: VDD
[ERROR PDN-0179] Unable to repair all channels.

Cause

The asap7 macro grid halo (2.0 um) equals MACRO_ROWS_HALO_X/Y (2 um).

  • tapcell cuts the rows 2 um from the macro and snaps them down to the row grid. Under fakeram u38955 (bottom edge y=76.256), the top row ends at y=74.25.
  • The macro grid claims M3–M5 from y=74.256, which is the macro edge minus the 2.0 um halo.

The VDD followpin on that row edge (74.241–74.259) crosses into the claimed area. Any M2→M5 via stack on it (about 74.226–74.273) is rejected as obstructed. Normally the rail runs on past the macro and gets a via there. Here the pocket between u49927 and u49934 is narrower than u38955, so no via position is left and the rail stays floating. The repair channel is stretched up over the macro because it reaches for the next M6 VDD strap. That stretch is a symptom, not the cause.

Fix

Change the macro grid halo to 1.9 um so it stays inside the 2 um row halo.

With the change, swerv_wrapper's do-2_4_floorplan_pdn passes, and its remaining PDN warnings are a subset of the ones it gave before.

This script is the default asap7 PDN_TCL, so coralnpu, cva6 and riscv32i are affected as well. Their metrics may move.

The macro grid halo (2.0) equaled MACRO_ROWS_HALO_X/Y (2). Rows snap
down to the site grid, so the followpin on the row edge next to a macro
straddles the halo boundary and every via onto it is obstructed by the
macro grid. When that row sits entirely under the macro (a pocket
between macros, as in swerv_wrapper) the rail cannot be connected
anywhere and pdngen fails with PDN-0179.

Shrink the macro grid halo to 1.9 so it stays inside the row halo.

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>
@maliberty maliberty self-assigned this Oct 23, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-23T21:05:56.653481Z
We couldn’t complete this review. Comment @codex review to try again.
34e2502 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reduces the macro grid halo values from 2.0 to 1.9 in the OpenROAD PDN grid strategy script for ASAP7 to prevent blocking the followpin and vias on the row edge next to a macro. The review feedback recommends dynamically calculating these halo values from the MACRO_ROWS_HALO_X and MACRO_ROWS_HALO_Y environment variables rather than hardcoding them, ensuring the script remains robust if those variables are customized.

@openroad-ci

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit 7a4371d · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

@maliberty

Copy link
Copy Markdown
Member Author

all designs passed, pr-merge failed in reporting.

@maliberty
maliberty merged commit 0b6c450 into The-OpenROAD-Project:master Oct 24, 2026
10 of 12 checks passed
@maliberty
maliberty deleted the asap7-pdn-macro-halo branch October 24, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants