Repository navigation
docker: the image carries tools/FakeRAM2.0 - #4786
Merged
Merged
Conversation
flow/scripts/memories/gen_memories.py runs tools/FakeRAM2.0/run.py,
found relative to itself. The image copies flow/ and tools/AutoTuner but
not tools/FakeRAM2.0, so every AUTO_MEMORIES flow run from the image
stops at the memories step:
/usr/bin/python3: can't open file
'/OpenROAD-flow-scripts/tools/FakeRAM2.0/run.py': [Errno 2] No such
file or directory
No design in CI sets AUTO_MEMORIES today, so CI on master does not show
it; a PR that adds one fails there (asap7/cva6 in The-OpenROAD-Project#4777).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
flow/scripts/memories/gen_memories.pyrunstools/FakeRAM2.0/run.py, found relative to itself. The image's last stage copiesflow/andtools/AutoTuner, but nottools/FakeRAM2.0, so everyAUTO_MEMORIESflow run from the image stops at the memories step:No design in CI sets
AUTO_MEMORIEStoday, so master's CI does not show it. A PR that adds one fails there: asap7/cva6 in #4777.The fix is one
COPYline next totools/AutoTuner.Test
A build with this repository as context and its
.dockerignore, of the same line on a small base image, putsrun.pywheregen_memories.pylooks for it:CI on this PR builds the image, but it runs no
AUTO_MEMORIESdesign, so the end-to-end check is #4777'spr-mergeonce this is in.🤖 Generated with Claude Code