Repository navigation
Finish the Ubuntu 26.04 image defaults - #4791
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the project's environment and Docker configurations from Ubuntu 22.04 to Ubuntu 26.04, simplifies the Yosys commands in the documentation, and refactors the container entrypoint script claude-entrypoint.sh alongside adding a regression test suite for it. The review feedback highlights two key improvements for the entrypoint script: updating the home directory in /etc/passwd using usermod when reusing an existing user to ensure tool compatibility, and adjusting the sequence of file creation so that .hushlogin is correctly owned by the mapped user instead of root.
| mkdir -p "${USER_HOME}" | ||
| export HOME="${USER_HOME}" | ||
| chown "${HOST_UID}:${HOST_GID}" "${USER_HOME}" | ||
| touch "${USER_HOME}/.hushlogin" |
There was a problem hiding this comment.
Creating .hushlogin with touch after running chown on ${USER_HOME} results in the .hushlogin file being owned by root:root (since the entrypoint script runs as root at this stage). This can prevent the mapped user from modifying or deleting the file.
To fix this, create the file first and then perform a recursive chown on the home directory to ensure all files within it are correctly owned by the mapped user.
| mkdir -p "${USER_HOME}" | |
| export HOME="${USER_HOME}" | |
| chown "${HOST_UID}:${HOST_GID}" "${USER_HOME}" | |
| touch "${USER_HOME}/.hushlogin" | |
| mkdir -p "${USER_HOME}" | |
| export HOME="${USER_HOME}" | |
| touch "${USER_HOME}/.hushlogin" | |
| chown -R "${HOST_UID}:${HOST_GID}" "${USER_HOME}" |
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
69dd7b1 to
5a17c12
Compare
The container engine creates ~/.cache as root when it mounts ~/.cache/bazel. Bazelisk then cannot create ~/.cache/bazelisk, and bazel fails with "permission denied". The home directory now matches the mounted cache for every UID, so this also affects UID 1000. The entrypoint now gives the user ownership of ~/.cache. The change is not recursive, so the mounted cache stays as it is. The regression check now reproduces the root-owned ~/.cache. Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@users.noreply.github.com>
7a57ddd
into
The-OpenROAD-Project:master
Use Ubuntu 26.04 for the Docker defaults and documentation builds.
Assemble the runtime image from matching published flow-tool and OpenROAD installations, retain their installed libraries, and keep flow results writable for users.
Update the examples to use Ubuntu 26.04 and the built-in Slang command.
Keep the mapped user's home at the settings mount when Ubuntu already has an account with the host UID.
This preserves settings and cache access for the default Linux UID 1000.
The runtime image built locally.
Separate non-root probes started OpenROAD, Yosys, Slang, KLayout, and kepler-formal.
The retained entrypoint regression test passed for existing UID 1000 and new UID 2000.