Skip to content

Finish the Ubuntu 26.04 image defaults - #4791

Merged
vvbandeira merged 6 commits into
The-OpenROAD-Project:masterfrom
vvbandeira:ubuntu26-cleanup
Nov 16, 2026
Merged

vvbandeira merged 6 commits into
The-OpenROAD-Project:masterfrom
vvbandeira:ubuntu26-cleanup

Conversation

@vvbandeira

Copy link
Copy Markdown
Member

Use Ubuntu 26.04 for the Docker defaults and documentation builds.
Assemble the runtime image from matching published flow-tool and OpenROAD installations, retain their installed libraries, and keep flow results writable for users.
Update the examples to use Ubuntu 26.04 and the built-in Slang command.

Keep the mapped user's home at the settings mount when Ubuntu already has an account with the host UID.
This preserves settings and cache access for the default Linux UID 1000.

The runtime image built locally.
Separate non-root probes started OpenROAD, Yosys, Slang, KLayout, and kepler-formal.
The retained entrypoint regression test passed for existing UID 1000 and new UID 2000.

@vvbandeira
vvbandeira requested a review from a team as a code owner November 5, 2026 14:41
@vvbandeira
vvbandeira requested review from sombraSoft and removed request for a team November 5, 2026 14:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the project's environment and Docker configurations from Ubuntu 22.04 to Ubuntu 26.04, simplifies the Yosys commands in the documentation, and refactors the container entrypoint script claude-entrypoint.sh alongside adding a regression test suite for it. The review feedback highlights two key improvements for the entrypoint script: updating the home directory in /etc/passwd using usermod when reusing an existing user to ensure tool compatibility, and adjusting the sequence of file creation so that .hushlogin is correctly owned by the mapped user instead of root.

Comment thread docker/claude-entrypoint.sh Resolved
Comment thread docker/claude-entrypoint.sh Outdated
Comment on lines 35 to 38
mkdir -p "${USER_HOME}"
export HOME="${USER_HOME}"
chown "${HOST_UID}:${HOST_GID}" "${USER_HOME}"
touch "${USER_HOME}/.hushlogin"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Creating .hushlogin with touch after running chown on ${USER_HOME} results in the .hushlogin file being owned by root:root (since the entrypoint script runs as root at this stage). This can prevent the mapped user from modifying or deleting the file.

To fix this, create the file first and then perform a recursive chown on the home directory to ensure all files within it are correctly owned by the mapped user.

Suggested change
mkdir -p "${USER_HOME}"
export HOME="${USER_HOME}"
chown "${HOST_UID}:${HOST_GID}" "${USER_HOME}"
touch "${USER_HOME}/.hushlogin"
mkdir -p "${USER_HOME}"
export HOME="${USER_HOME}"
touch "${USER_HOME}/.hushlogin"
chown -R "${HOST_UID}:${HOST_GID}" "${USER_HOME}"

@openroad-ci

openroad-ci commented Nov 5, 2026 •

Copy link
Copy Markdown
Member

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit a3bbbc5 · Jenkins build #4 · Baseline: build · View build on dashboard

62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.

⚠️ 57 design(s) were compared against an approximate baseline, not the build at this PR's merge base, so changes already on the target branch can show up as regressions.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
The container engine creates ~/.cache as root when it mounts
~/.cache/bazel. Bazelisk then cannot create ~/.cache/bazelisk, and
bazel fails with "permission denied". The home directory now matches
the mounted cache for every UID, so this also affects UID 1000.

The entrypoint now gives the user ownership of ~/.cache. The change
is not recursive, so the mounted cache stays as it is. The regression
check now reproduces the root-owned ~/.cache.

Signed-off-by: Vitor Bandeira <vvbandeira@precisioninno.com>
Signed-off-by: Vitor Bandeira <vvbandeira@users.noreply.github.com>
@vvbandeira
vvbandeira merged commit 7a57ddd into The-OpenROAD-Project:master Nov 16, 2026
8 of 11 checks passed
@vvbandeira
vvbandeira deleted the ubuntu26-cleanup branch November 16, 2026 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants