From 25635232db77e16052ddd14e9532a3f8538ab2ec Mon Sep 17 00:00:00 2001 From: Augusto Berndt Date: Thu, 5 Nov 2026 14:53:12 +0000 Subject: [PATCH 1/2] fix: set PYTHON_EXE default in make issue vars files 0772900e2 switched the Tcl scripts from python3 to $::env(PYTHON_EXE), but generate-vars.sh leaves out *_EXE vars and only the yosys run-me script exported it. So OpenROAD-stage issues (e.g. global_place) failed in erase_non_stage_variables. Write a portable python3 default into both vars.sh and vars.tcl, and remove the export that only the yosys run-me script had. Signed-off-by: Augusto Berndt Co-authored-by: Claude --- flow/scripts/global_place.tcl | 1 + flow/util/generate-vars.sh | 3 +++ flow/util/makeIssue.sh | 1 - 3 files changed, 4 insertions(+), 1 deletion(-) diff --git a/flow/scripts/global_place.tcl b/flow/scripts/global_place.tcl index 6a2d583d26..2ce4600ff8 100644 --- a/flow/scripts/global_place.tcl +++ b/flow/scripts/global_place.tcl @@ -57,6 +57,7 @@ if { $place_ios } { lappend global_placement_args -place_ios } +global_placement_debug -pause 100 -update 100 proc do_placement { global_placement_args } { set all_args [concat [list -density [place_density_with_lb_addon] \ -pad_left $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \ diff --git a/flow/util/generate-vars.sh b/flow/util/generate-vars.sh index 54a88852d1..27feedf4fe 100755 --- a/flow/util/generate-vars.sh +++ b/flow/util/generate-vars.sh @@ -16,6 +16,9 @@ EXCLUDED_VARS+='|COMMAND_LINE_ARGS' EXCLUDED_PATTERNS="_EXE$|PATH$|_CMD$|\." echo 'export FLOW_HOME=${FLOW_HOME:-$(pwd)}' > $1.sh +# *_EXE paths are machine specific and excluded below; default to PATH lookup. +echo 'export PYTHON_EXE=${PYTHON_EXE:-python3}' >> $1.sh +echo 'if { ![info exists env(PYTHON_EXE)] } { set env(PYTHON_EXE) python3 }' > $1.tcl while read -r VAR; do if [[ ${VAR} != *"="* ]] ; then diff --git a/flow/util/makeIssue.sh b/flow/util/makeIssue.sh index 6941a98071..6ebe28ce4b 100755 --- a/flow/util/makeIssue.sh +++ b/flow/util/makeIssue.sh @@ -88,7 +88,6 @@ cat > ${RUN_ME_SCRIPT} < Date: Thu, 5 Nov 2026 14:56:08 +0000 Subject: [PATCH 2/2] remove accidental file addition Signed-off-by: Augusto Berndt --- flow/scripts/global_place.tcl | 1 - 1 file changed, 1 deletion(-) diff --git a/flow/scripts/global_place.tcl b/flow/scripts/global_place.tcl index 2ce4600ff8..6a2d583d26 100644 --- a/flow/scripts/global_place.tcl +++ b/flow/scripts/global_place.tcl @@ -57,7 +57,6 @@ if { $place_ios } { lappend global_placement_args -place_ios } -global_placement_debug -pause 100 -update 100 proc do_placement { global_placement_args } { set all_args [concat [list -density [place_density_with_lb_addon] \ -pad_left $::env(CELL_PAD_IN_SITES_GLOBAL_PLACEMENT) \