Repository navigation
Add useful-skew flag to CTS script - #4794
openroad-ci wants to merge 5 commits into
Conversation
Signed-off-by: luis201420 <luisemv@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the CTS_USEFUL_SKEW environment variable to the clock tree synthesis arguments in flow/scripts/cts.tcl. The feedback notes that this newly introduced environment variable must also be defined in variables.json or variables.yaml to ensure proper documentation, typing, and validation within the OpenROAD Flow Scripts environment.
| append_env_var cts_args CTS_BUF_LIST -buf_list 1 | ||
| append_env_var cts_args CTS_LIB_NAME -library 1 | ||
|
|
||
| append_env_var cts_args CTS_USEFUL_SKEW -useful_skew 0 |
There was a problem hiding this comment.
The newly introduced environment variable CTS_USEFUL_SKEW is not defined in flow/scripts/variables.json. All environment variables used in the flow scripts must be declared in variables.json (or variables.yaml) to ensure they are properly documented, typed, and validated within the OpenROAD Flow Scripts environment.
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
bcda51a to
cb24a81
Compare
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
The
useful_skewflag has been added to the CTS script, allowing it to be specified for any design where this method is desired.