Repository navigation
asap7: fix V5.M6.AUX.2 and V7.M8.AUX.2 edge orientation in KLayout DRC - #4799
Merged
maliberty merged 1 commit intoNov 7, 2026
Conversation
In asap7_tech_1x_201209.lef, Metal 6 and Metal 8 are horizontal routing layers. In flow/platforms/asap7/drc/asap7.lydrc, rules V5.M6.AUX.2 and V7.M8.AUX.2 check that via width matches metal width along the direction perpendicular to metal length using .edges.with_angle(90). Because M6 and M8 are horizontal, selecting 90-degree edges checks vertical edges along the length of the metal instead of across its width. This falsely flags legal standard vias (e.g. VIA56 and VIA78) and wide power strap vias as DRC violations. Fix both rules by selecting horizontal edges with .edges.with_angle(0), matching the M4 check on rule V3.M4.AUX.2. Fixes The-OpenROAD-Project#4738. Signed-off-by: Bandham Balaji <bandhambalaji@gmail.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ASAP7 DRC script (asap7.lydrc) by changing the angle parameter from 90 to 0 in the with_angle filter for V5/M6 and V7/M8 enclosure checks (rules V5.M6.AUX.2 and V7.M8.AUX.2). This ensures the correct edge direction is evaluated perpendicular to the metal routing. I have no additional feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
maliberty
approved these changes
Nov 7, 2026
Member
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In asap7_tech_1x_201209.lef, Metal 6 and Metal 8 are horizontal routing layers. In flow/platforms/asap7/drc/asap7.lydrc, rules V5.M6.AUX.2 and V7.M8.AUX.2 check that via width matches metal width along the direction perpendicular to metal length using .edges.with_angle(90).
Because M6 and M8 are horizontal, selecting 90-degree edges checks vertical edges along the length of the metal instead of across its width. This falsely flags legal standard vias (e.g. VIA56 and VIA78) and wide power strap vias as DRC violations.
Fix both rules by selecting horizontal edges with .edges.with_angle(0), matching the M4 check on rule V3.M4.AUX.2.
Fixes #4738.