Repository navigation
Conversation
The-OpenROAD-Project#4800 moved defaults.py and non_stage_variables.py onto variables.yaml and removed yaml_to_json.py and the CI check that kept the JSON in sync, but left the JSON itself in place to avoid conflicts while it was in review. Nothing reads, generates or checks it any more. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request deletes the JSON configuration file containing definitions, descriptions, and stage associations for various OpenROAD flow variables (such as ABC_AREA, ABC_DRIVER_CELL, and SYNTH_ARGS). There are no review comments, and I have no feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before,
flow/scripts/variables.jsonwas still tracked after #4800, a 1,623-line copy ofvariables.yamlthat nothing used and that went stale with everyvariables.yamlchange.Now, it is deleted, and
variables.yamlis the only variable list.Why it was left behind: #4800 moved
defaults.pyandnon_stage_variables.pyontovariables.yamland removedyaml_to_json.pyand the CI sync check, but kept the JSON to avoid conflicts while in review, with its deletion promised as a separate PR. This is that PR.Checked: on master,
git grepoutside thetools/submodules forvariables.json,yaml_to_json, and JSON reads in scripts,*.mk,flow/Makefile,.githubworkflows, docs, tests,docker/etc,.gitignoreand.gitattributes: nothing reads, generates or checks the file.🤖 Generated with Claude Code