Repository navigation
chore: drop what the bazel surface removal left behind - #4806
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes all Bazel build support, configuration files, helper scripts, and related documentation from the repository. This includes the deletion of Bazel-specific installation scripts, GCP credential helpers, and Bazel-related sections in the local build documentation. As there are no review comments provided, I have no feedback to offer.
The-OpenROAD-Project#4501 removed ORFS's MODULE.bazel and BUILD files, and c9e1ba4 the plumbing that only they referenced. These files and doc sections describe or serve that build, and nothing reads them now: flow/README.md the bazel targets of every design (<n>_synth, ..., <n>_test) and how to add a design's BUILD.bazel. Those targets and design.bzl are gone. docs/user/BuildLocally.md "Using Bazel to build OpenROAD and run the ORFS flow" runs `bazelisk run //:install_for_bazel`, a target that went with the root BUILD.bazel. "Build OpenROAD and run a few ORFS flows with Bazel" builds designs/asap7/gcd targets and bumps a MODULE.bazel, neither of which exists. bazel/install.sh its only caller was //:install_for_bazel. bazel/README.md describes flow/BUILD.bazel examples and the bazel-orfs version pin in MODULE.bazel. bazel/slang-compat/README a placeholder for when ORFS is the root module consuming tools/OpenROAD through git_override. Without a MODULE.bazel, ORFS is never the root module. flow/util/cred_helper.py a GCP credential helper for the bazel artifact repository (fabdb02); nothing references it. flow/util/open_plots.sh an xdg-open wrapper for the bazel plot_congestion target, removed in The-OpenROAD-Project#4085 and The-OpenROAD-Project#4096. The /bazel/ line in CODEOWNERS goes with the directory. .bazelversion and .bazelignore stay: bazelisk in docker/Dockerfile.claude reads .bazelversion. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
7c0ad2a to
65f818c
Compare
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
vvbandeira
left a comment
There was a problem hiding this comment.
flow/designs/README.md still documents the removed in-tree targets: design.bzl (line 12) and bazelisk test //flow/designs/... (lines 37-50).
flow/test/openroad.sh runs ./external/_main~_repo_rules~openroad/openroad, a Bazel external path, and nothing calls it.
Please delete both in this PR, or say why they stay.
The .github/dependabot.yml comment on MODULE.bazel (line 3) is now stale too.
Review follow-up. These also only served the removed bazel build:
flow/designs/README.md documents the design.bzl targets and
`bazelisk test //flow/designs/...`; neither
exists.
flow/test/openroad.sh runs openroad from a Bazel external repo
path; nothing calls it.
.github/dependabot.yml the comment that MODULE.bazel is not
covered; there is no MODULE.bazel.
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
|
@vvbandeira Fixed. |
Before: after #4501 and #4524 removed ORFS's bazel surface, a README, two doc sections, three files under
bazel/and twoflow/utilscripts still described or served that build. Followingdocs/user/BuildLocally.mdorflow/README.mdends at a target that does not exist.Now: they are gone. 396 lines deleted, nothing added.
flow/README.mddesign.bzl, deleted in #4501docs/user/BuildLocally.md, two bazel sections//:install_for_bazel,designs/asap7/gcd:gcd_floorplanandMODULE.bazelno longer existbazel/install.sh//:install_for_bazelbazel/README.mdflow/BUILD.bazeland theMODULE.bazelpinbazel/slang-compat/READMEflow/util/cred_helper.pyflow/util/open_plots.shplot_congestiontarget removed in #4085/#4096/bazel/inCODEOWNERS.bazelversionand.bazelignorestay:docker/Dockerfile.claudeinstalls bazelisk, which reads.bazelversion.Check:
git grepfinds no remaining reference to any deleted path.🤖 Generated with Claude Code