Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the developer guide to document unit tests that are not executed by CI, providing commands to run them locally. The review feedback correctly points out that the shell loop for running memory tests should fail early if any individual test fails, rather than silently masking failures if the final test succeeds.
CI runs flow/test/test_*.py. Some unit tests elsewhere in the tree are run on demand and are not hooked up to CI, so a green CI run says nothing about them and they may need some maintenance before they pass. Say so in the developer guide. Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
oharboe
force-pushed
the
docs/local-unit-tests
branch
from
November 8, 2026 09:30
c03eca6 to
002b99b
Compare
Collaborator
Author
|
Superseded by #4808: hook these tests up to CI instead of documenting that they are not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before: CI runs
flow/test/test_*.py. Some unit tests elsewhere in the tree are run on demand and are not hooked up to CI, and nothing in the docs says so.Now:
docs/contrib/DeveloperGuide.mdsays so, and that such tests may need some maintenance before they pass.🤖 Generated with Claude Code