Repository navigation
Conversation
do-floorplan, do-place, do-cts and do-grt each run their own stage; do-route also ran do-5_1_grt first. It predates do-grt, and was not trimmed when do-grt was added. The comment that lists the supported do-<stage> targets gains do-grt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates flow/Makefile to separate the global routing stage (do-grt) from the routing stage (do-route). Specifically, it removes the do-5_1_grt dependency from the do-route target and updates the documentation comments to include do-grt as a supported interface. There are no review comments, so I have no feedback to provide.
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline. |
flow/Makefile: master dropped do-5_route.sdc from do-route (every .odb now carries its .sdc); this branch dropped do-5_1_grt. do-route keeps both changes: do-5_2_route do-5_3_fillcell do-5_route. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
do-routeran global routing and then detailed routing, whiledo-floorplan,do-place,do-ctsanddo-grteach run only their own stage.Now:
do-routeruns only route (do-5_2_route do-5_3_fillcell do-5_route do-5_route.sdc), like the others, and the comment listing the supporteddo-<stage>targets includesdo-grt.do-routedates from before global routing was a stage of its own;do-grtwas added later (4616652, "add do-grt target, congruent with gui_grt"), anddo-routekept running it too. A flow that runs one stage per invocation had to call route's steps one by one to avoid redoing global routing: bazel-orfs's route stage runsdo-5_2_route do-5_3_fillcell do-5_route do-5_route.sdcfor that reason.make routeand the other file targets are unchanged; nothing in ORFS's docs, tests or scripts callsdo-route.Testing
asap7/gcdthroughctswith master's Makefile, then:make do-route: global and detailed route.make do-grtthenmake do-route:5_1_grt,5_2_route,5_3_fillcelland5_route.odb, and5_1_grt.sdcand5_route.sdc, are byte-identical to master's.make do-routestraight aftercts: stops at[ERROR ORD-0007] .../5_1_grt.odb does not exist., before writing anything.🤖 Generated with Claude Code