Repository navigation
Add Antenna information back to nangate45 - #4816
Open
openroad-ci wants to merge 8 commits into
Open
openroad-ci wants to merge 8 commits into
openroad-ci wants to merge 8 commits into
Conversation
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Nangate45 platform configuration to use the standard NangateOpenCellLibrary.macro.lef file. It modifies the FILLCELL macros to have the SPACER class and adds a new TAPCELL_X1 macro. The review feedback suggests cleaning up the newly added TAPCELL_X1 macro by removing commented-out code and using lowercase 'core' for consistency with other macros in the LEF file.
Comment on lines
+9634
to
+9635
| #CLASS CORE ; | ||
| CLASS CORE WELLTAP ; |
Contributor
Member
Author
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Commit 62 design(s) checked — 3 with regression(s), 0 without a comparable baseline. ❌ nangate45/ariane133 base — 1 failing metric(s)
❌ nangate45/gcd base — 1 failing metric(s)
❌ nangate45/swerv base — 1 failing metric(s)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #597
The RECT LEF workaround for polygon pins is no longer needed since openDB now fully supports polygon geometries, avoiding antenna data loss.
Changes
Highlight results
These are the designs with the greatest degradation in their metrics:
swerv: (It requires an update to the metrics.)
ariane133: (It requires an update to the metrics.)
bp_multi:
gcd: (It requires an update to the metrics.)
cva6:
No antenna violations are found in any of these designs. This is because the tech LEF does not contain rules for the antenna checker.