Skip to content

Add Antenna information back to nangate45 - #4816

Open
openroad-ci wants to merge 8 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:ant-add-info-ng45
Open

openroad-ci wants to merge 8 commits into
The-OpenROAD-Project:masterfrom
The-OpenROAD-Project-staging:ant-add-info-ng45

Conversation

@openroad-ci

Copy link
Copy Markdown
Member

Fixes #597
The RECT LEF workaround for polygon pins is no longer needed since openDB now fully supports polygon geometries, avoiding antenna data loss.

Changes

  • Update config.mk to use NangateOpenCellLibrary.macro.lef
  • Adapt the LEF file for proper use within the workflow.

Highlight results

These are the designs with the greatest degradation in their metrics:
swerv: (It requires an update to the metrics.)

  • finish__timing__setup__tns ~9%

ariane133: (It requires an update to the metrics.)

  • finish__timing__setup__tns ~20%

bp_multi:

  • 1 setup violation on finish stage

gcd: (It requires an update to the metrics.)

  • detailedroute__route__wirelength ~15%

cva6:

  • finish__timing__setup__tns ~12%

No antenna violations are found in any of these designs. This is because the tech LEF does not contain rules for the antenna checker.

Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>
Signed-off-by: luis201420 <luisemv@precisioninno.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Nangate45 platform configuration to use the standard NangateOpenCellLibrary.macro.lef file. It modifies the FILLCELL macros to have the SPACER class and adds a new TAPCELL_X1 macro. The review feedback suggests cleaning up the newly added TAPCELL_X1 macro by removing commented-out code and using lowercase 'core' for consistency with other macros in the LEF file.

Comment on lines +9634 to +9635
#CLASS CORE ;
CLASS CORE WELLTAP ;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Remove the commented-out #CLASS CORE ; line to keep the LEF file clean, and use lowercase core for the CLASS definition to maintain consistency with the other macros in this file (e.g., CLASS core SPACER ;).

  CLASS core WELLTAP ;

@luis201420
luis201420 requested a review from maliberty November 10, 2026 03:18
@openroad-ci

Copy link
Copy Markdown
Member Author

🔍 QoR check

Metrics reflect the PR merge build — i.e. what will land on the target branch.

Commit d2e9c89 · Jenkins build #1 · Baseline: build · View build on dashboard

62 design(s) checked — 3 with regression(s), 0 without a comparable baseline.

❌ nangate45/ariane133 base — 1 failing metric(s)
Metric target base delta limit band
finish__timing__setup__tns -260.713 -216.840 -20.233% -260.208 PeriodPadding 20.000%
❌ nangate45/gcd base — 1 failing metric(s)
Metric target base delta limit band
detailedroute__route__wirelength 5114.000 4421.000 15.675% 5084.150 Padding 15.000%
❌ nangate45/swerv base — 1 failing metric(s)
Metric target base delta limit band
cts__timing__setup__tns -227.190 -180.281 -26.020% -216.337 PeriodPadding 20.000%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Antenna information back to nangate45

2 participants