Skip to content

gui: add grt heatmap to save_image -web - #12045

Open
mikesinouye wants to merge 4 commits into
The-OpenROAD-Project:masterfrom
mikesinouye:gui
Open

mikesinouye wants to merge 4 commits into
The-OpenROAD-Project:masterfrom
mikesinouye:gui

Conversation

@mikesinouye

@mikesinouye mikesinouye commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Plumb existing global route routing congestion heatmap support from GUI to save_image -web.

Type of Change

  • New feature

Impact

New heatmap option.

Verification

  • I have verified that the local build succeeds (./etc/Build.sh).
  • I have run the relevant tests and they pass.
  • My code follows the repository's formatting guidelines.
  • I have included tests to prevent regressions.
  • I have signed my commits (DCO).

Signed-off-by: Mike Inouye <mikeinouye@google.com>
@mikesinouye
mikesinouye requested a review from a team as a code owner October 29, 2026 00:24
@mikesinouye
mikesinouye requested a review from maliberty October 29, 2026 00:24
@mikesinouye
mikesinouye marked this pull request as draft October 29, 2026 00:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for a global routing congestion heatmap overlay (routing_congestion) to the web tile generator. The changes include updating the TileVisibility configuration, implementing the drawRoutingCongestionLayer method to render the heatmap, integrating the new layer into the pseudo-layer definitions, and updating the documentation and unit tests. There are no review comments to assess, and the changes appear correct and well-tested, so I have no feedback to provide.

Signed-off-by: Mike Inouye <mikeinouye@google.com>
@mikesinouye

Copy link
Copy Markdown
Contributor Author

@Logikable would you be able to take a look when you get a chance? Just a minor nice to have for the route flow bringup internally

@Logikable Logikable left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useful, thanks :)

Comment thread src/web/test/cpp/TestSaveImage.cpp Resolved
Signed-off-by: Mike Inouye <mikeinouye@google.com>
@mikesinouye
mikesinouye marked this pull request as ready for review October 29, 2026 18:48
@maliberty

Copy link
Copy Markdown
Member

I'm confused, there is already a routing congestion heatmap
image

@mikesinouye

mikesinouye commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor Author

I'm confused, there is already a routing congestion heatmap image

That's the for the GUI, which is already hooked up, this is for the save_image -web command (separate code). The functionality is already there, I don't need to build the heatmap, just needs the plumbing to save_image.

renamed the ambiguous PR name to make that more clear.

@mikesinouye mikesinouye changed the title web: add grt heatmap gui: add grt heatmap to save_image -web Nov 2, 2026
@mikesinouye

Copy link
Copy Markdown
Contributor Author

Hi @maliberty , and feedback to provide?

@maliberty
maliberty enabled auto-merge November 5, 2026 05:44
@mikesinouye

Copy link
Copy Markdown
Contributor Author

//src/pdn/test:pads_black_parrot_grid_define-tcl_test failed, seems unrelated. Should I retrigger CI?

…ROAD into pr12045-merge

Signed-off-by: Matt Liberty <mliberty@precisioninno.com>

# Conflicts:
#	src/web/test/cpp/TestSaveImage.cpp
auto-merge was automatically disabled November 5, 2026 21:08

Head branch was pushed to by a user without write access

@mikesinouye

Copy link
Copy Markdown
Contributor Author

@maliberty sorry to bump again, CI passed this time, auto merge got disabled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants