Repository navigation
rsz: In repairNet, update parasitics only for net driver - #12099
Merged
Merged
Conversation
Signed-off-by: Mike Inouye <mikeinouye@google.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates src/rsz/src/RepairDesign.cc to replace global parasitic updates and delay calculations with more targeted calls. Specifically, estimate_parasitics_->updateParasitics() is replaced with estimate_parasitics_->ensureWireParasitic(drvr_pin, net), and sta_->findDelays(drvr) is replaced with graph_delay_calc_->findDelays(drvr) across multiple blocks in RepairDesign::repairNet. I have no feedback to provide.
Contributor
|
No QoR impact? |
Contributor
Author
|
None of our designs showed a diff, I think it may be possible in an edge case when the values align exactly but I am not sure it is likely to happen in practice. |
Contributor
|
Ok. Thank you for the enhancement! |
jhkim-pii
approved these changes
Nov 3, 2026
Contributor
Author
|
Thank you for the quick review! |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As a runtime optimization, within
RepairDesign::repairNet(), only update parasitics and delays for the net's driver vertex. In the current code,sta_->findDelays(drvr)runsSta::delayCalcPreamble()which runs full levelization and delay calc across all dirty nets, which is not necessary.repairDesign()performs a final call to update parasitics.OpenROAD/src/rsz/src/RepairDesign.cc
Line 386 in 30e4295
Type of Change
Impact
Runtime improvement for large designs.
Verification
./etc/Build.sh).