Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the access point path segment properties (is_ap_pathseg_ and ap_loc_) are correctly preserved when copying frPathSeg objects and when constructing drPathSeg from frPathSeg. It also introduces a new unit test, pathSegTest.cpp, to verify this behavior across copy and round-trip conversions. There are no review comments, so I have no feedback to provide.
Keep the AP flag and global origin when copying frPathSeg or converting it to drPathSeg. Routing workers use that anchor to own complete pin escapes instead of clipping them as ordinary wire. Check AP and ordinary segment copies and conversions in gc_unittest. Signed-off-by: Philippe Sauter <phsauter@iis.ee.ethz.ch>
phsauter
force-pushed
the
drt-preserve-ap-segments
branch
from
November 4, 2026 21:23
fa4a641 to
e2e1b62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Keep the AP flag and global origin when copying
frPathSegor converting it todrPathSeg. Routing workers use it to own complete pin escapes instead of clipping them as ordinary wires (which are handled with different clipping and removal rules).Type of Change
Impact
Keeps the AP escape as belonging to the worker, avoiding it being handled like an ordinary wire.
This may change some AP routing or how it is being handled, for me it is more a correctness fix that got in the way of debugging other things.
Verification
./etc/Build.sh).