Skip to content

perf: keep the emulator out of the qemu-user package for later builds - #51

Closed
The127 wants to merge 5 commits into
mainfrom
emulator-cache
Closed

The127 wants to merge 5 commits into
mainfrom
emulator-cache

Conversation

@The127

@The127 The127 commented Oct 11, 2026

Copy link
Copy Markdown
Owner

A cross build used to unpack the qemu-user package on every run to find one program. On an arm64 host the amd64 program sits near the end of the package, so most of it was decompressed each time.

Now the first cross build keeps the program in the download store under its pinned digest. Later builds read it from there. A program that does not match its pin is refused and removed. miso prune treats the kept program like any other download.

Docs: I checked them. Nothing needed a change.

The127 and others added 2 commits October 11, 2026 13:31
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: karo <karolin.kostial@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: karo <karolin.kostial@gmail.com>
@codecov

codecov Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.51613% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.12%. Comparing base (5196ee1) to head (3f7f580).

Files with missing lines Patch % Lines
internal/download/downloadtest/kept.go 0.00% 9 Missing ⚠️
internal/download/pinned.go 90.00% 1 Missing ⚠️
internal/emulator/ready.go 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   56.10%   56.12%   +0.02%     
==========================================
  Files         288      288              
  Lines        4761     4780      +19     
==========================================
+ Hits         2671     2683      +12     
- Misses       2090     2097       +7     
Flag Coverage Δ
unit 56.12% <64.51%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The127 and others added 3 commits October 11, 2026 13:39
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: karo <karolin.kostial@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: karo <karolin.kostial@gmail.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: karo <karolin.kostial@gmail.com>
@The127

The127 commented Oct 11, 2026

Copy link
Copy Markdown
Owner Author

Closing: miso will boot a builder VM of the target architecture with the host's qemu-system instead of downloading qemu-user.

@The127 The127 closed this Oct 11, 2026
@The127
The127 deleted the emulator-cache branch October 11, 2026 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant