fix: avoid empty appcast args on macOS bash

Author: Alexander5015

.github/scripts/tests/test_release_workflow.py

@@ -51,6 +51,12 @@ def test_beta_appcast_retry_is_one_idempotent_step(self) -> None:
         self.assertNotIn("Push published beta appcast (attempt", self.release)
         self.assertIn("for attempt in 1 2 3 4 5; do", self.release)
 
+    def test_stable_appcast_does_not_expand_an_empty_array_with_nounset(self) -> None:
+        self.assertNotIn('"${CHANNEL_ARGS[@]}"', self.release)
+        self.assertIn("APPCAST_ARGS=(", self.release)
+        self.assertIn('APPCAST_ARGS+=(--channel "${{ env.BETA_CHANNEL_NAME }}")', self.release)
+        self.assertIn('"${APPCAST_ARGS[@]}"', self.release)
+
     def test_nightly_schedule_remains_independent(self) -> None:
         self.assertIn("schedule:", self.nightly)
         self.assertIn('NIGHTLY_BRANCH: dev', self.nightly)

.github/workflows/release.yml

@@ -467,22 +467,22 @@ jobs:
           test -x "$RUNNER_TEMP/generate_appcast" || {
             echo "::error::$RUNNER_TEMP/generate_appcast missing or not executable"; exit 1;
           }
-          CHANNEL_ARGS=()
+          APPCAST_ARGS=(
+            --ed-key-file -
+            --link "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/releases"
+            --download-url-prefix "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/releases/download/v${VERSION}/"
+            --embed-release-notes
+          )
           APPCAST_OUTPUT="$RUNNER_TEMP/appcast-stable.xml"
           if [[ "${IS_BETA}" == "true" ]]; then
-            CHANNEL_ARGS=(--channel "${{ env.BETA_CHANNEL_NAME }}")
+            APPCAST_ARGS+=(--channel "${{ env.BETA_CHANNEL_NAME }}")
             APPCAST_OUTPUT="$RUNNER_TEMP/appcast-${{ env.BETA_CHANNEL_NAME }}.xml"
           else
             cp updater/appcast.xml "$APPCAST_OUTPUT"
           fi
-          printf '%s' "$SPARKLE_PRIVATE_KEY" | "$RUNNER_TEMP/generate_appcast" \
-            --ed-key-file - \
-            --link "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/releases" \
-            --download-url-prefix "${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}/releases/download/v${VERSION}/" \
-            --embed-release-notes \
-            "${CHANNEL_ARGS[@]}" \
-            -o "$APPCAST_OUTPUT" \
-            Release/
+          APPCAST_ARGS+=(-o "$APPCAST_OUTPUT")
+          printf '%s' "$SPARKLE_PRIVATE_KEY" | \
+            "$RUNNER_TEMP/generate_appcast" "${APPCAST_ARGS[@]}" Release/
 
       - name: Create or refresh draft GitHub release
         id: prepare_release