Repository navigation
Enable Synthetic DAQ Support for Real Camera Devices - #1233
kevin-m-dean merged 13 commits into
Conversation
|
Implemented the inactive-camera guard in Why this guard is needed
Before this change, the Hamamatsu implementation fired a DCAM software trigger whenever The new device-level guard returns immediately when Regression coverage verifies both sides of the contract:
Follow-up: formalize software-trigger capabilityThis PR also exposes a broader inconsistency: camera backends do not currently have a uniform, formalized Software trigger mode. Some cameras advertise only External/Internal trigger sources, while microscope setup currently forces [P2] Only force Software mode for cameras that support it. As a follow-up, the SyntheticDAQ setup should gate that configuration change on each camera's Validation
|
|
@annie-xd-wang, I know you have tested all of these camera systems, so your hardware results carry more weight here. An AI-assisted review flagged three points, and I wanted to see whether you think any of them are worth considering:
These may be false positives in light of your real-camera testing; I mainly wanted to put them in front of you before we merge. |
|
Issue 2: Fixed |
No description provided.