Skip to content

Commit de2f1f6

Browse files
chore: can't believe I have to do this much to rename a button
1 parent 3f21ad4 commit de2f1f6

4 files changed

Lines changed: 9 additions & 9 deletions

File tree

‎frontend/e2e/authors-directory.spec.js‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ test('add author suggests frequent names and still accepts custom names after a
5959
return route.fulfill({ json: [] })
6060
})
6161
await page.goto('/authors')
62-
await page.getByRole('button', { name: 'Add Author' }).click()
62+
await page.getByRole('button', { name: 'Add author' }).click()
6363
const input = page.getByRole('combobox', { name: 'Name *' })
6464
await expect(page.getByRole('option')).toHaveText(['Jane Smith8 papers', 'Alex Doe2 papers'])
6565
await page.screenshot({ path: testInfo.outputPath('author-suggestions.png') })
@@ -71,7 +71,7 @@ test('add author suggests frequent names and still accepts custom names after a
7171
await page.getByRole('button', { name: 'Create', exact: true }).click()
7272
await expect(page.getByRole('link', { name: 'Open Alex Doe' })).toBeVisible()
7373
failSuggestions = true
74-
await page.getByRole('button', { name: 'Add Author' }).click()
74+
await page.getByRole('button', { name: 'Add author' }).click()
7575
await expect(page.getByRole('alert')).toContainText('Suggestions unavailable')
7676
await input.fill('My Own Author')
7777
await page.getByRole('button', { name: 'Create', exact: true }).click()

‎frontend/e2e/library-workflows.spec.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ test('authors directory uses compact responsive cards and preserves author creat
413413
return second.top - first.bottom
414414
})).toBeGreaterThan(0)
415415
await page.screenshot({ path: 'test-results/authors-cards-mobile.png', fullPage: true, animations: 'disabled' })
416-
await page.getByRole('button', { name: 'Add Author', exact: true }).click()
416+
await page.getByRole('button', { name: 'Add author', exact: true }).click()
417417
await page.getByPlaceholder('e.g. John Smith').fill('New Researcher')
418418
await page.getByRole('button', { name: 'Create', exact: true }).click()
419419
await expect(directory.getByRole('link', { name: 'Open New Researcher' })).toBeAttached()

‎frontend/src/pages/Authors.jsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function AddAuthorModal({ onClose, onCreate }) {
3737
return (
3838
<div className="fixed inset-0 bg-black/50 flex items-center justify-center z-50" onClick={onClose}>
3939
<div className="bg-white rounded-xl shadow-xl w-full max-w-md p-6" onClick={e => e.stopPropagation()}>
40-
<h2 className="text-lg font-semibold text-slate-800 mb-4">Add Author</h2>
40+
<h2 className="text-lg font-semibold text-slate-800 mb-4">Add author</h2>
4141
<form onSubmit={handleSubmit} className="space-y-3">
4242
<AuthorNameCombobox value={name} onChange={setName} />
4343
<div>
@@ -129,7 +129,7 @@ export default function Authors() {
129129
<div className="mb-5 flex flex-wrap items-center justify-between gap-3">
130130
<h1 className="text-2xl font-semibold tracking-tight text-slate-900">Authors</h1>
131131
<button onClick={() => setShowAdd(true)} className="inline-flex items-center gap-1.5 rounded-lg bg-slate-800 px-3 py-2 text-xs font-medium text-white hover:bg-slate-700">
132-
<Icon name="add" className="text-[16px]" />Add Author
132+
<Icon name="add" className="text-[16px]" />Add author
133133
</button>
134134
</div>
135135
<div className="mb-4 flex flex-wrap items-center justify-between gap-3">

‎frontend/src/pages/Authors.test.jsx‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ it('creates an author with social profiles and retains values after failure', as
176176
authorsApi.create.mockRejectedValueOnce(new Error('Save failed')).mockResolvedValueOnce({ id: 'a1', name: 'Jane' })
177177
render(<MemoryRouter><Authors /></MemoryRouter>)
178178
await act(async () => { await vi.advanceTimersByTimeAsync(0) })
179-
fireEvent.click(screen.getByRole('button', { name: 'Add Author' }))
179+
fireEvent.click(screen.getByRole('button', { name: 'Add author' }))
180180
fireEvent.change(screen.getByPlaceholderText('e.g. John Smith'), { target: { value: 'Jane' } })
181181
fireEvent.change(screen.getByRole('textbox', { name: 'LinkedIn' }), { target: { value: 'https://www.linkedin.com/in/jane' } })
182182
fireEvent.change(screen.getByRole('textbox', { name: 'X / Twitter' }), { target: { value: 'https://x.com/jane' } })
@@ -194,7 +194,7 @@ it('shows frequent names immediately and supports filtering and keyboard selecti
194194
authorsApi.suggestions.mockResolvedValue([{ name: 'Jane Smith', paperCount: 5 }, { name: 'Alex Doe', paperCount: 2 }])
195195
authorsApi.create.mockResolvedValue({ id: 'a1', name: 'Alex Doe' })
196196
render(<MemoryRouter><Authors /></MemoryRouter>)
197-
await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Add Author' })) })
197+
await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Add author' })) })
198198
const input = screen.getByRole('combobox', { name: 'Name *' })
199199
expect(screen.getAllByRole('option').map(option => option.textContent)).toEqual(['Jane Smith5 papers', 'Alex Doe2 papers'])
200200
fireEvent.change(input, { target: { value: ' alex ' } })
@@ -214,7 +214,7 @@ it('supports mouse selection, dismissing suggestions, and entering a custom name
214214
authorsApi.suggestions.mockResolvedValue([{ name: 'Jane Smith', paperCount: 3 }])
215215
authorsApi.create.mockResolvedValue({ id: 'a1', name: 'Custom Name' })
216216
render(<MemoryRouter><Authors /></MemoryRouter>)
217-
await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Add Author' })) })
217+
await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Add author' })) })
218218
const input = screen.getByRole('combobox')
219219
fireEvent.click(screen.getByRole('option'))
220220
expect(input).toHaveValue('Jane Smith')
@@ -233,7 +233,7 @@ it('allows manual creation when suggestions fail and can retry suggestions', asy
233233
authorsApi.list.mockResolvedValue([])
234234
authorsApi.suggestions.mockRejectedValueOnce(new Error('Unavailable')).mockResolvedValueOnce([])
235235
render(<MemoryRouter><Authors /></MemoryRouter>)
236-
await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Add Author' })) })
236+
await act(async () => { fireEvent.click(screen.getByRole('button', { name: 'Add author' })) })
237237
expect(screen.getByRole('alert')).toHaveTextContent('Could not load suggestions: Unavailable')
238238
fireEvent.change(screen.getByRole('combobox'), { target: { value: 'My Author' } })
239239
expect(screen.getByRole('button', { name: 'Create', exact: true })).toBeEnabled()

0 commit comments

Comments
 (0)