Skip to content

Commit cadabde

Browse files
author
Michael Gasperini
committed
ci(dependabot): pin @types/vscode to the engine floor
The VS Code typings must match the minimum engine version declared by the extension; any update moves the types ahead of the floor and breaks the compatibility test, so ignore all updates for that package. The setup-node pin assertion accepts v6 and v7 while the action update lands.
1 parent 4a90c02 commit cadabde

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

‎.github/dependabot.yml‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,4 +49,3 @@ updates:
4949
# The @types/vscode major tracks the engine floor declared in package.json;
5050
# advancing the types ahead of the floor breaks the compatibility tests.
5151
- dependency-name: "@types/vscode"
52-
update-types: ["version-update:semver-major"]

‎test/metadata.test.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -221,7 +221,7 @@ test('CI validates securely across supported platforms and editor versions', ()
221221
assert.equal(workflow.match(/if: github\.event_name != 'schedule'/g)?.length, 2);
222222
assert.match(workflow, /permissions:\s+contents: read/);
223223
assert.match(workflow, /actions\/checkout@[0-9a-f]{40} # v7/);
224-
assert.match(workflow, /actions\/setup-node@[0-9a-f]{40} # v6/);
224+
assert.match(workflow, /actions\/setup-node@[0-9a-f]{40} # v[67]/);
225225
assert.doesNotMatch(workflow, /uses: actions\/(?:checkout|setup-node)@v\d+/);
226226
});
227227

0 commit comments

Comments
 (0)