Skip to content

Commit c0eb3db

Browse files
authored
fix(ci): restore repository permission vetters (NVIDIA#3875)
Signed-off-by: Piotr Mlocek <pmlocek@nvidia.com>
1 parent cf1bbb9 commit c0eb3db

2 files changed

Lines changed: 6 additions & 25 deletions

File tree

‎.github/copy-pr-bot.yaml‎

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,3 @@
11
enabled: true
22
auto_sync_draft: false
33
auto_sync_ready: true
4-
vetters_override:
5-
- alangou
6-
- derekwaynecarr
7-
- drew
8-
- elezar
9-
- johnnygreco
10-
- johntmyers
11-
- kirit93
12-
- krishicks
13-
- matthewgrossman
14-
- mrunalp
15-
- pimlock
16-
- purp
17-
- SDAChess
18-
- shailendra-nv
19-
- sjenning
20-
- TaylorMutch
21-
- zredlined

‎CI.md‎

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,10 @@ For local test commands see [TESTING.md](TESTING.md). For PR conventions see [CO
88

99
PR CI that runs on NVIDIA self-hosted runners uses NVIDIA's copy-pr-bot. The bot mirrors trusted PR commits to internal `pull-request/<N>` branches in this repository. The gated workflows trigger on pushes to those branches, not on the original PR.
1010

11-
When a PR is not mirrored automatically, only the GitHub users listed in
12-
`.github/copy-pr-bot.yaml` under `vetters_override` can admit its current
13-
revision with `/ok to test <SHA>`. The list is a snapshot of the codeowners
14-
and selected repository maintainers; update it when those people change.
15-
This setting does not change the bot's automatic trust policy for ready PRs.
11+
When a PR is not mirrored automatically, anyone with Write, Maintain, or Admin
12+
access to this repository can admit its current revision with
13+
`/ok to test <SHA>`. This includes external maintainers with repository access.
14+
Manual admission does not change the bot's automatic trust policy for ready PRs.
1615

1716
`Branch Checks` run automatically after copy-pr-bot mirrors the PR. `Required CI Gates` posts PR-head statuses that verify the mirror exists, is current, and ran the expected push-based workflows. E2E suites are opt-in because they are more expensive and publish temporary images.
1817

@@ -347,11 +346,11 @@ Prerequisites:
347346
Flow:
348347

349348
1. Open the PR. The vouch check confirms first-time external contributors are vouched (otherwise their PRs are auto-closed).
350-
2. If copy-pr-bot does not mirror it automatically, a listed vetter reviews the diff and comments `/ok to test <SHA>` with the latest commit SHA. Fork location alone does not determine whether a PR is mirrored automatically.
349+
2. If copy-pr-bot does not mirror it automatically, a maintainer with Write access or greater reviews the diff and comments `/ok to test <SHA>` with the latest commit SHA. Fork location alone does not determine whether a PR is mirrored automatically.
351350
3. After `/ok to test`, copy-pr-bot mirrors to `pull-request/<N>`. From here the flow is identical to automatically admitted PRs: `Required CI Gates` verifies the mirror and required push workflows, and maintainers apply the E2E label when the extra suites are needed.
352351
4. When the PR is ready to merge, maintainers add it to the merge queue so the queued integration state is tested before it reaches `main`.
353352

354-
Important: if a PR requires manual admission, every new commit needs another `/ok to test <new-SHA>` from a listed vetter before push-based CI will run on it. If a label is applied while the mirror is stale, `E2E Label Help` will post a comment explaining what's needed.
353+
Important: if a PR requires manual admission, every new commit needs another `/ok to test <new-SHA>` from a maintainer with Write access or greater before push-based CI will run on it. If a label is applied while the mirror is stale, `E2E Label Help` will post a comment explaining what's needed.
355354

356355
## Merge queue
357356

0 commit comments

Comments
 (0)