Skip to content

Feature/ios track fullscreen controls - #1669

Closed
CHaNGeTe wants to merge 2 commits into
TheWidlarzGroup:masterfrom
24i:feature/ios-track-fullscreen-controls
Closed

CHaNGeTe wants to merge 2 commits into
TheWidlarzGroup:masterfrom
24i:feature/ios-track-fullscreen-controls

Conversation

@CHaNGeTe

Copy link
Copy Markdown
Contributor

Tracks fullscreen state when changed via controls, and call callbacks if needed

@ashnfb

ashnfb commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

@CHaNGeTe this is very similar to fixes I have been making; although I added an additional bit of code to handle situations with fullscreen rotation. Let me know if you want to merge your PR, and I can keep my additional code for the future.

nfb-onf@a17b183

@CHaNGeTe

Copy link
Copy Markdown
Contributor Author

Sorry Ash! Didn't remember you were working on this.

Depending on the ETA of your PR we can release this as quick fix. Or wait for your PR itself. What do you think?

@ashnfb

ashnfb commented Jul 15, 2019

Copy link
Copy Markdown
Contributor

hi @CHaNGeTe, would you mind if I update this PR with additional changes?

@CHaNGeTe

Copy link
Copy Markdown
Contributor Author

feel free!

Comment thread package.json
{
"name": "react-native-video",
"version": "4.4.3",
"version": "4.4.4",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 4.4.5 I guess?

@jonathangreco

Copy link
Copy Markdown

Is this PR add a props to remove fullscreen button on iOS ?

@ashnfb

ashnfb commented Sep 4, 2019

Copy link
Copy Markdown
Contributor

@jonathangreco it is not. It's code for optional callbacks when entering or exiting fullscreen

@luco

luco commented Dec 3, 2019

Copy link
Copy Markdown

merge this

@alimek

alimek commented Mar 26, 2020

Copy link
Copy Markdown

this fixed problem for me with #1319

had to use react-native-orientation and

  onFullscreenPlayerWillPresent = () => {
    Orientation.unlockAllOrientations();
  };

  onFullscreenPlayerWillDismiss = () => {
    Orientation.lockToPortrait();
  };

thanks!

adamivancza added a commit to adamivancza/react-native-video that referenced this pull request May 14, 2020
@juancarlosqr

Copy link
Copy Markdown

@cobarx @jenshandersson @ashnfb @n1ru4l any notion when this could be merged? 🙏🏼

@gazialankus

Copy link
Copy Markdown

This works well in iOS12.4, iPhone6.

However, In iOS 13.6, iPhone 11, this freezes the video when making it fullscreen. When trying to close fullscreen it crashes. This line is the culprit: _fullscreenPlayerPresented = YES

@gazialankus

Copy link
Copy Markdown

putting it in dispatch_async(dispatch_get_main_queue(), ^{ }); fixes iPhone 11!

@gazialankus

Copy link
Copy Markdown

I sent a PR to this branch that wants to PR here :D 24i#15

@stale

stale Bot commented Apr 19, 2022

Copy link
Copy Markdown

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If you are having a similar problem, please open a new issue and reference this one instead of commenting on a stale or closed issue.

@stale stale Bot added the stale Closed due to inactivity or lack or resources label Apr 19, 2022
@hueniverse hueniverse added stale Closed due to inactivity or lack or resources and removed stale Closed due to inactivity or lack or resources 1 labels Apr 20, 2022
@hueniverse hueniverse closed this Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Platform: iOS stale Closed due to inactivity or lack or resources

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants