Code review, fixes, and unit tests for the reporting/logging plugins

[mkarlesky]

Summary

Code review pass across the test-reporting/logging plugins
(report_build_warnings_log, report_tests_raw_output_log, the four
report_tests_*_stdout plugins, their shared base classes, and
report_tests_log_factory), which collectively had zero unit test
coverage apart from one trivial one-assertion spec. Found and fixed real
bugs — data corruption, malformed XML, a broken CI-integration escape
function, thread-safety races — none of which existing tests could have
caught, then built the coverage that should have caught them, with zero
filesystem/stdout interaction in any test.

Bugs fixed

• Thread-safety race in report_build_warnings_log: the write path
  iterated the collected-warnings hash with no lock, while collection into
  that same hash was always mutex-guarded.
• XML/HTML injection: report_tests_log_factory's JUnit reporter never
  escaped failure messages; CppUnit and HTML escaped nothing at all in test
  names, messages, or filepaths.
• Cross-reporter data corruption: JUnit's escaping mutated the shared
  results structure's own strings in place (gsub!); since the same
  results object is handed to every configured reporter in turn, one
  reporter's escaping could silently leak into another's output depending
  on :reports: order in project configuration.
• Mislabeled ignored tests: the GTest-like report tagged ignored tests
  as passes, rendering them [ OK ] with their message dropped, and its
  footer counts didn't sum to its header total when ignores existed.
• Broken TeamCity escaping: escape used single-quoted '\r'/'\n'
  (literal backslash-r/backslash-n, not real control characters) — verified
  empirically that a real embedded newline passed straight through,
  corrupting/splitting ##teamcity[...] service messages.
• Missing IDE report features: no multi-line message reindentation
  (unlike its "identical" pretty sibling) and no summary banner color
  decoration.

Refactoring

• New ReportLogWriterPlugin base class shared by report_build_warnings_log
  and report_tests_raw_output_log — one mutex discipline, one FileWrapper-based
  write path, instead of two independently-hand-rolled (and inconsistently
  correct) copies.
• New shared xml_escape/html_escape on TestsReporter, used
  non-destructively by all three affected reporters.
• New shared test_report_preamble/reflow_message/decorate_summary_banner
  on PluginReportinator, now used by both the pretty and IDE stdout
  templates — the exact duplication that let IDE quietly drift out of sync
  with pretty in the first place.
• TestsReporter#write and the TeamCity plugin's teamcity_service_message
  now write through injectable seams (FileWrapper, a @stream reference)
  instead of raw File.open/bare puts — the reason none of this had any
  test coverage before.
• eval-based dynamic reporter instantiation replaced with Object.const_get.

Testing

• Full unit suite: 3204 examples, 0 failures (up from 3112 baseline before
  this and the prior PR in this branch's lineage).
• First-ever unit test coverage added for 13 previously-untested
  files/classes across all the plugins above.
• Live end-to-end smoke tests: a fresh example project's full 86-test suite
  through the default (pretty) template, and all four report_tests_log_factory
  report formats generated and validated as well-formed JSON/XML against a
  real build.
• Existing report_tests_raw_output_log system test re-verified green
  after the shared-base refactor.

No documentation or Changelog updates — deferred to a follow-on plan per
plan.

🤖 Generated with Claude Code