Skip to content

feat: add a Report issue button to the header - #23

Merged
BenGlut merged 1 commit into
TigerTag-Project:mainfrom
Ptitlouis6012:feat/header-report-issue-button
Sep 6, 2026
Merged

BenGlut merged 1 commit into
TigerTag-Project:mainfrom
Ptitlouis6012:feat/header-report-issue-button

Conversation

@Ptitlouis6012

Copy link
Copy Markdown
Contributor

Overrides Starlight's SocialIcons component to append a link to https://github.com/TigerTag-Project/TigerSystem-Docs/issues/new, styled with the same accent-high/black pairing as the hero's primary button so it reads as the one call-to-action color on the page.

Overrides Starlight's SocialIcons component to append a link to
https://github.com/TigerTag-Project/TigerSystem-Docs/issues/new, styled
with the same accent-high/black pairing as the hero's primary button so
it reads as the one call-to-action color on the page.
@vercel

vercel Bot commented Sep 6, 2026

Copy link
Copy Markdown

@Ptitlouis6012 is attempting to deploy a commit to the Tiger-Project Team on Vercel.

A member of the Team first needs to authorize it.

@BenGlut
BenGlut merged commit 3519bad into TigerTag-Project:main Sep 6, 2026
1 check failed
BenGlut added a commit that referenced this pull request Sep 6, 2026
Follow-up to #23, whose idea and design are kept as they were.

Drops rel="me" — that attribute claims the target is another profile of
the same person, which a new-issue form is not.

Hides the link below Starlight's social-row breakpoint. It was rendering
at 0x0 there: invisible to sighted users, still announced to a screen
reader, and unreachable by either.

And carries the page into the issue. A report now arrives titled with
the path and pre-filled with it, in the reader's own language, instead
of costing a round-trip to ask where the problem was.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@BenGlut

BenGlut commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator

Merged — thanks, this was clean and well scoped, and the accent-high/black reasoning was the right call: it reads as the page's single call-to-action colour.

Verified before merging by building it on top of main: the site builds, sync-docs --check and check-i18n pass, and both locales render their label. Worth knowing that the CI did not run on this PR — it came from a fork, and GitHub holds workflows for a first-time contributor until a maintainer approves them, so the only check shown was Vercel failing for the same reason. That is on us to sort out, not on you.

Three follow-ups landed in e214bb3, all small, none of them changing your design:

  • Dropped rel="me". That attribute asserts the target is another profile of the same person — the IndieWeb/Mastodon verification convention. A new-issue form is not a profile.
  • Hidden below Starlight's social-row breakpoint. I measured the link at 0×0 on a 375 px viewport: Starlight collapses that row, so the button was invisible to sighted users while still being announced to screen readers, and reachable by neither. display: none under 50rem takes it out of the accessibility tree too.
  • The link now carries the page. It opens the issue form pre-filled with the path, in the reader's own language — so a report arrives already saying where the problem is instead of costing a round-trip to ask.

The third one is the reason the button will actually be useful rather than just present. Nice addition.

@Ptitlouis6012
Ptitlouis6012 deleted the feat/header-report-issue-button branch September 15, 2026 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants