Repository navigation
Commit 5584c73
committed
fix(ci): publish releaseType=release + force Node 24 for JS actions
═══ macOS artifacts missing from v1.4.6 release — root cause + fix ═══
Symptom — v1.4.6 release on GitHub had only Linux + Windows assets;
all macOS .dmg / .zip / blockmap / latest-mac.yml were missing.
Root cause — concurrent jobs racing to publish:
• Windows job is fast (~3 min, no notarization). It uses
softprops/action-gh-release@v2 which creates a PUBLISHED release.
• macOS job is slow (~6 min, Apple notarization). It uses
`electron-builder --publish always`. electron-builder's default
publishing type is `draft`. When it tried to push to v1.4.6, it
found an EXISTING release (created by softprops) of type
`release`, refused to mix types, and silently skipped all
uploads with: "GitHub release not created — reason=existing
type not compatible with publishing type tag=v1.4.6 ...
existingType=release publishingType=draft".
Fix:
publish.releaseType = "release"
Now electron-builder publishes in `release` mode too, matching what
softprops creates, so it appends to the existing release instead of
skipping. Both publish paths now converge on the same release.
═══ Node 20 deprecation warning ═══
GitHub Actions emits a warning that JS-based actions running on
Node 20 will be forced to Node 24 by June 2nd, 2026 and Node 20
removed September 16th, 2026. softprops/action-gh-release@v2 still
ships Node 20 today.
Fix:
env.FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 = "true" (workflow level)
This opts every JS action into Node 24 immediately, aligning with
our actions/setup-node@v5 + node-version 24 already used for the
build. Silences the warning and pre-empts the forced cutover.1 parent d68f6d7 commit 5584c73
2 files changed
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
11 | 20 | | |
12 | 21 | | |
13 | 22 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
37 | | - | |
| 37 | + | |
| 38 | + | |
38 | 39 | | |
39 | 40 | | |
40 | 41 | | |
| |||
0 commit comments