Repository navigation
Commit 70da3df
committed
v1.4.10 — fix Windows auto-update (publisherName leak)
The v1.4.9 Windows .exe shipped unsigned (Trusted Signing CI
secrets missing from the build env), and electron-builder had
silently leaked the mac.identity string ("Developer ID
Application: 3D France (RT4W5WC9P2)") into the cross-platform
app-update.yml as the expected publisherName.
Existing installs running v1.4.7/v1.4.8 hit
"Could not check: New version 1.4.9 is not signed by the
application owner: publisherNames: Developer ID Application:
3D France (RT4W5WC9P2)"
and refused to install the update.
Fix: explicitly set build.win.publisherName: null in package.json
to override the leak. Combined with the existing
verifyUpdateCodeSignature: false, electron-updater now skips
publisher-name verification on Windows. Integrity is still
checked via the SHA-512 hash written into latest.yml that
electron-updater verifies after every download — no integrity
regression, only the certificate-name comparison is removed.
When Trusted Signing keys come back, just remove the
publisherName: null line and full signature verification resumes.
No user-facing changes beyond the update path itself working
again.1 parent 622f65f commit 70da3df
2 files changed
Lines changed: 12 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
49 | 49 | | |
50 | 50 | | |
51 | 51 | | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
52 | 61 | | |
53 | 62 | | |
54 | 63 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | | - | |
| 3 | + | |
4 | 4 | | |
5 | 5 | | |
6 | 6 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
| 64 | + | |
64 | 65 | | |
65 | 66 | | |
66 | 67 | | |
| |||
0 commit comments