Repository navigation
Commit 760df93
committed
fix(ci): force a space-free Windows artifact name to satisfy electron-updater
Symptom — auto-updater on installed v1.4.5 clients was failing:
"Could not check: Cannot download .../v1.4.5/Tiger-Studio-Manager-Setup-1.4.5.exe, status 404"
Root cause — three different filenames for the same physical .exe:
• dist/ → "Tiger Studio Manager Setup 1.4.5.exe" (literal spaces, electron-builder default)
• Asset on the GitHub Release → "Tiger.Studio.Manager.Setup.1.4.5.exe" (GitHub auto-rewrites spaces → dots on upload)
• latest.yml (manifest) → "Tiger-Studio-Manager-Setup-1.4.5.exe" (electron-builder URL-encodes spaces → dashes)
The dashes in latest.yml didn't match the dotted asset name, so the
auto-updater hit 404 every time.
Fix:
win.artifactName = "Tiger-Studio-Manager-Setup-${version}.${ext}"
This forces the local filename in dist/ to be space-free, so:
• dist/ → Tiger-Studio-Manager-Setup-1.4.5.exe
• Asset on Release → Tiger-Studio-Manager-Setup-1.4.5.exe (no rewrite, no spaces to fix)
• latest.yml → Tiger-Studio-Manager-Setup-1.4.5.exe (matches)
For the already-shipped v1.4.5 release: latest.yml has been patched
in place via `gh release upload --clobber` so the existing asset
(dotted name) is still discoverable. Users who hit the 404 already
will succeed on the next "Check for updates" since electron-updater
re-fetches latest.yml every time.1 parent 719ffe5 commit 760df93
1 file changed
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
| 57 | + | |
57 | 58 | | |
58 | 59 | | |
59 | 60 | | |
| |||
0 commit comments