Skip to content

Commit ca4ea12

Browse files
committed
CI: Disable the discrete parameter state test for DSPModulePluginDemo
juce::AudioParameterBool::setValue keeps the raw value it is given, so the JUCE demo fails the new test at strictness level 8 and above. Skip that one test for the demo until it is fixed in JUCE.
1 parent f9bad80 commit ca4ea12

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

‎.github/workflows/build.yaml‎

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,9 @@ jobs:
128128
shell: bash
129129
run: |
130130
# Paths must be single quoted for bash not to escape the Windows backslash character \ used in absolute paths
131-
${{ env.APP_DIR }}/${{ matrix.test-binary }} validate --strictness-level 10 '${{ env.PLUGIN_CACHE_PATH }}/DSPModulePluginDemo_artefacts/Release/VST3/DSPModulePluginDemo.vst3'
131+
# "Discrete parameter state restoration" is disabled for DSPModulePluginDemo until juce::AudioParameterBool::setValue
132+
# snaps to 0 or 1: https://forum.juce.com/t/pluginval-can-set-an-audioparameterbools-to-odd-values/50971
133+
${{ env.APP_DIR }}/${{ matrix.test-binary }} validate --strictness-level 10 --disabled-tests "Discrete parameter state restoration" '${{ env.PLUGIN_CACHE_PATH }}/DSPModulePluginDemo_artefacts/Release/VST3/DSPModulePluginDemo.vst3'
132134
${{ env.APP_DIR }}/${{ matrix.test-binary }} validate --strictness-level 10 '${{ env.PLUGIN_CACHE_PATH }}/MultiOutSynthPlugin_artefacts/Release/VST3/MultiOutSynthPlugin.vst3'
133135
134136
- name: Validate JUCE Plugin examples (AU)
@@ -143,7 +145,7 @@ jobs:
143145
killall -9 AudioComponentRegistrar # kick the AU registrar
144146
# Intentionally uses the deprecated "--validate" flat flag to keep the
145147
# backwards-compatible alias covered (this step is continue-on-error).
146-
${{ env.APP_DIR }}/${{ matrix.test-binary }} --strictness-level 10 --validate ~/Library/Audio/Plug-Ins/Components/DSPModulePluginDemo.component
148+
${{ env.APP_DIR }}/${{ matrix.test-binary }} --strictness-level 10 --disabled-tests "Discrete parameter state restoration" --validate ~/Library/Audio/Plug-Ins/Components/DSPModulePluginDemo.component
147149
148150
- name: Codesign (macOS)
149151
if: ${{ matrix.name == 'macOS' }}

0 commit comments

Comments
 (0)