Skip to content

Commit f9bad80

Browse files
committed
Fix the plugin state restoration test's binary state check never running
The check is documented as running at strictness level 8 and above but compared the test's own level (6) rather than the run's, so it was never executed.
1 parent 38e61d7 commit f9bad80

2 files changed

Lines changed: 2 additions & 1 deletion

File tree

‎CHANGELIST.md‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
- Added a "Discrete parameter state restoration" test (strictness 8) which checks a discrete parameter has the same value after restoring a state, whatever value it held beforehand. This fails for parameters that keep the raw normalised value from the host instead of mapping it to a step (e.g. `juce::AudioParameterBool`)
1717
- Fixed false failures in the "Plugin state restoration" test where the first parameter was compared against the last value sent by a previous test rather than the plugin's own value
1818
- Below strictness level 8, two-step (on/off) parameters are now only sent 0 or 1 when tests randomise parameter values. Arbitrary values are still sent to them at level 8 and above, and to all other parameters at every level
19+
- Fixed the "Plugin state restoration" test's exact binary state comparison never running. It was documented as running at strictness level 8 and above but checked the test's own level instead of the run's
1920
- Enabled the editor stress and extreme (real-time allocation / oversized block) tests that were present in the source tree but had not been compiled into the build
2021

2122
### 1.0.5

‎source/tests/BasicTests.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,7 +398,7 @@ struct PluginStateTestRestoration : public PluginTest
398398
parameter->getName(1024) + juce::String(" not restored on setStateInformation"));
399399
}
400400

401-
if (strictnessLevel >= 8)
401+
if (ut.getOptions().strictnessLevel >= 8)
402402
{
403403
// Read state again and compare to what we set
404404
auto duplicateState = callGetStateInformationOnMessageThreadIfVST3 (instance);

0 commit comments

Comments
 (0)