Skip to content

Commit d37dac1

Browse files
gauravclaude
andcommitted
Mark the notebook tests as unit tests so CI actually runs them
The only pytest job on main is `uv run pytest -m unit -v`, so an unmarked test file is silently deselected: 30 tests that look like coverage and execute never. This has already happened once in this repo (#112 merged six tests that had never run), which is why the root CLAUDE.md calls it out. This branch predates the marker's introduction on main, so register `unit` in pyproject.toml too — verbatim from main, so the two merge cleanly. Verified: `pytest -m unit` now selects 30 and deselects 25. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
1 parent 8c9690b commit d37dac1

2 files changed

Lines changed: 7 additions & 0 deletions

File tree

pyproject.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ packages = ["src"]
3434
# (including node_modules) during collection.
3535
testpaths = ["tests"]
3636
timeout = 300
37+
markers = [
38+
"unit: unit tests that do not require network access",
39+
]
3740

3841
[dependency-groups]
3942
dev = [

tests/log_analysis/test_nameres_log_notebook.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
import pandas as pd
2020
import pytest
2121

22+
# Without this the only pytest job in CI (`pytest -m unit`) deselects the whole
23+
# file, and it looks like passing coverage while testing nothing.
24+
pytestmark = pytest.mark.unit
25+
2226
NOTEBOOK = (
2327
Path(__file__).parents[2] / "log-analysis" / "nameres" / "analyze_nameres_logs.py"
2428
)

0 commit comments

Comments
 (0)